From 6dd040912a632881e0cc8c5ac281b6688075a42f Mon Sep 17 00:00:00 2001 From: James Daniels Date: Wed, 5 Feb 2020 21:16:59 -0800 Subject: [PATCH 1/4] Removing the problematic share from the zone.js changes --- src/core/angularfire2.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/core/angularfire2.ts b/src/core/angularfire2.ts index 39c0c1b2d..ce1430757 100644 --- a/src/core/angularfire2.ts +++ b/src/core/angularfire2.ts @@ -90,8 +90,9 @@ export function ɵkeepUnstableUntilFirstFactory( // Run the subscribe body outside of Angular (e.g. calling Firebase SDK to add a listener to a change event) subscribeOn(schedulers.outsideAngular), // Run operators inside the angular zone (e.g. side effects via tap()) - observeOn(schedulers.insideAngular), - share() + observeOn(schedulers.insideAngular) + // This isn't working correctly #2309, #2314, #2312 + // share() ); } } From a5d081b2dc2a419ce5a2cd3e41a1b88f115383d0 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Wed, 5 Feb 2020 21:32:05 -0800 Subject: [PATCH 2/4] Build v5 --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index c350d34cc..f6c0c9561 100644 --- a/.travis.yml +++ b/.travis.yml @@ -25,6 +25,7 @@ matrix: branches: only: - master # otherwise pull requests get built twice + - v5 install: - | From f32a5fafbad9bf60fc99c6634411827035c185ec Mon Sep 17 00:00:00 2001 From: James Daniels Date: Wed, 5 Feb 2020 21:35:16 -0800 Subject: [PATCH 3/4] Changelog entry --- CHANGELOG.md | 9 +++++++++ package.json | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c8e1dd49f..4d28cd125 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,12 @@ + +## [5.4.2](https://github.com/angular/angularfire2/compare/5.4.1...5.4.2) (2020-02-06) + + +### Bug Fixes + +* **core:** fixing a problem with hot/cold observables resulting in missed events ([#2315](https://github.com/angular/angularfire2/issues/2315)) ([6dd0409](https://github.com/angular/angularfire2/commit/6dd0409)) + + ## [5.4.1](https://github.com/angular/angularfire2/compare/5.4.0...5.4.1) (2020-02-05) diff --git a/package.json b/package.json index d71f62dff..0335258e0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@angular/fire", - "version": "5.4.1", + "version": "5.4.2", "description": "The official library of Firebase and Angular.", "private": true, "scripts": { From ce8c4518b254b9c977f33a23861eb0ffc3d8f2ef Mon Sep 17 00:00:00 2001 From: James Daniels Date: Wed, 5 Feb 2020 21:41:02 -0800 Subject: [PATCH 4/4] Dropping the cache and matrix from travis, as I have in master --- .travis.yml | 28 +--------------------------- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/.travis.yml b/.travis.yml index f6c0c9561..a214e9198 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,38 +6,12 @@ node_js: addons: chrome: stable -cache: - yarn: true - directories: - - node_modules - - "$HOME/.npm" - - "$HOME/.cache" - -env: - - CANARY=false - - CANARY=true - -matrix: - fast_finish: true - allow_failures: - - env: CANARY=true - branches: only: - master # otherwise pull requests get built twice - v5 -install: - - | - if $CANARY; then - yarn upgrade && yarn add firebase@canary - else - if [ "$TRAVIS_BRANCH" = "master" -a "$TRAVIS_PULL_REQUEST" = "false" ]; then - yarn upgrade - else - yarn install --frozen-lockfile - fi - fi +install: yarn install --frozen-lockfile script: - yarn build