Skip to content

Commit 3e993b6

Browse files
devversionandrewseguin
authored andcommitted
fix(dialog): invalid text color in dark themes (#4849)
In dark themes the dialog container will have a dark background and the text should therefore have a light text color. Currently the text color is still dark on a dark background which causes the dialog to look bad in dark themes.
1 parent 6aaddbf commit 3e993b6

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/lib/dialog/_dialog-theme.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55

66
@mixin mat-dialog-theme($theme) {
77
$background: map-get($theme, background);
8+
$foreground: map-get($theme, foreground);
89

910
.mat-dialog-container {
1011
background: mat-color($background, dialog);
12+
color: mat-color($foreground, text);
1113
}
1214
}
1315

tools/gulp/packaging/build-tasks-gulp.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const htmlmin = require('gulp-htmlmin');
1515
* @param packageName Name of the package. Needs to be similar to the directory name in `src/`.
1616
* @param requiredPackages Required packages that will be built before building the current package.
1717
*/
18-
export function createPackageBuildTasks(packageName: string, requiredPackages: string[] = [], ) {
18+
export function createPackageBuildTasks(packageName: string, requiredPackages: string[] = []) {
1919
// To avoid refactoring of the project the package material will map to the source path `lib/`.
2020
const packageRoot = join(SOURCE_ROOT, packageName === 'material' ? 'lib' : packageName);
2121
const packageOut = join(DIST_ROOT, 'packages', packageName);

0 commit comments

Comments
 (0)