Skip to content

Commit b82a064

Browse files
committed
Update comments
1 parent 8482fed commit b82a064

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

tools/gulp/task_helpers.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,10 @@ export function isTravisPushBuild() {
208208
return process.env['TRAVIS_PULL_REQUEST'] === 'false';
209209
}
210210

211-
/** Open Google Cloud Storage for screenshots */
211+
/**
212+
* Open Google Cloud Storage for screenshots.
213+
* The files uploaded to google cloud are also available to firebase storage.
214+
*/
212215
export function openScreenshotsBucket() {
213216
let gcs = gcloud.storage({
214217
projectId: 'material2-screenshots',

tools/gulp/tasks/screenshots.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,10 @@ function diffScreenshot(filename: string, database: admin.database.Database,
139139
}
140140
}
141141

142-
/** Upload a list of filenames to firebase database as gold. */
142+
/**
143+
* Upload a list of filenames to firebase database as gold.
144+
* This is necessary for control panel since google-cloud is not available to client side.
145+
*/
143146
function setScreenFilenames(database: admin.database.Database,
144147
prNumber?: string) {
145148
let filenames: string[] = getLocalScreenshotFiles(SCREENSHOT_DIR);

0 commit comments

Comments
 (0)