Skip to content

Low contrast for code markup in docs with dark theme #15262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thanhpd opened this issue Feb 21, 2019 · 3 comments
Closed

Low contrast for code markup in docs with dark theme #15262

thanhpd opened this issue Feb 21, 2019 · 3 comments
Assignees
Labels
area: material.angular.io area: theming docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround

Comments

@thanhpd
Copy link

thanhpd commented Feb 21, 2019

What is the current behavior?

The documentation page with dark themes are displaying the code tags with an insufficient contrast ratio and are really hard to read

firefox_qtxhoxmenm
firefox_zd73sqcpts

What is the expected behavior?

Increase the contrast ratio for these tags so that it's easier to read.

Reference from WCAG:

The visual presentation of text and images of text has a contrast ratio of at least 4.5:1

What are the steps to reproduce?

  • Enable dark theme on the documentation page
  • The code tags can be found mostly in the Overview and API tab of each page

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular Material documentation, v. 7.3.1

@surfer19
Copy link

I made some investigation, I didn't found any purple texts but I found another 2.54 - 3.48 ratio, mostly in tags.

@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround docs This issue is related to documentation labels Apr 16, 2019
@twerske twerske self-assigned this May 24, 2021
@twerske
Copy link
Contributor

twerske commented May 24, 2021

Closed as this was fixed in angular/material.angular.io#635 - thanks for the attentiveness to accessibility of our docs @thanhpd!

@twerske twerske closed this as completed May 24, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material.angular.io area: theming docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Development

No branches or pull requests

4 participants