Skip to content

mat-select children do not have appropriate ARIA roles #16618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
univern72 opened this issue Jul 26, 2019 · 2 comments
Closed

mat-select children do not have appropriate ARIA roles #16618

univern72 opened this issue Jul 26, 2019 · 2 comments
Labels
Accessibility This issue is related to accessibility (a11y)

Comments

@univern72
Copy link

univern72 commented Jul 26, 2019

Reproduction

View source of any mat-select example:
https://material.angular.io/components/select/examples

Steps to reproduce:

  1. Use a mat-select
  2. Look at its children in the DOM

Expected Behavior

mat-select has role=listbox, so its children should have role=option

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/listbox_role#Description

Actual Behavior

mat-select children do not have role=option

matselectariaissue

Environment

Other notes

This was caught by running the accessibility developer tools audit.

@andrewseguin andrewseguin added the Accessibility This issue is related to accessibility (a11y) label Jul 31, 2019
@andrewseguin
Copy link
Contributor

Yes, the select's children should have that role. Ideally all the options are direct children and in the DOM, but our current design does not consider this.

We do have an open issue to rework the select with accessibility in mind - check out #11083 for details. I'll close this in favor of keeping one issue related to select's a11y but thanks for reporting the issue

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y)
Projects
None yet
Development

No branches or pull requests

2 participants