Skip to content

Modal Documentation wrong #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbeckenbach opened this issue Feb 17, 2017 · 1 comment · Fixed by #3186
Closed

Modal Documentation wrong #3155

mbeckenbach opened this issue Feb 17, 2017 · 1 comment · Fixed by #3186
Labels
docs This issue is related to documentation help wanted The team would appreciate a PR from the community to address this issue

Comments

@mbeckenbach
Copy link

mbeckenbach commented Feb 17, 2017 •
edited
Loading

There is an error on the documentation website (material.angular.io) regarding modals:

dialogRef.afterClosed.then

should be
dialogRef.afterClosed.subscribe

Tested in beta.1 and beta.2
@kara kara added docs This issue is related to documentation help wanted The team would appreciate a PR from the community to address this issue labels Feb 17, 2017
@comfroels comfroels mentioned this issue Feb 19, 2017
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
docs This issue is related to documentation help wanted The team would appreciate a PR from the community to address this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(dialog): change then to subscribe comfroels/material2
2 participants
@kara @mbeckenbach