Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 0eb5b76

Browse files
thorn0cnishina
authored andcommitted
fix(navigation): ignore unknown JS errors in IE (#4149)
The `err` object doesn't have the `code` property any more (Selenium Server Standalone 3.3.1 + IEDriver win32 3.3.0), so we need a new way to detect those errors. See #841
1 parent 4752ad1 commit 0eb5b76

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/browser.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,7 @@ export class ProtractorBrowser extends AbstractExtendedWebDriver {
900900
return url !== this.resetUrl;
901901
},
902902
(err: IError) => {
903-
if (err.code == 13) {
903+
if (err.code == 13 || err.name === 'JavascriptError') {
904904
// Ignore the error, and continue trying. This is
905905
// because IE driver sometimes (~1%) will throw an
906906
// unknown error from this execution. See

0 commit comments

Comments
 (0)