Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 25b1fa0

Browse files
committed
feat(jasmine): update jasmine dependency to 2.3.1
Updated from 2.1.1. See Jasmine's changelog at https://github.com/jasmine/jasmine/tree/master/release_notes Closes #1795. Closes #2094. Closes #1768.
1 parent a58ded5 commit 25b1fa0

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

lib/frameworks/jasmine2.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ RunnerReporter.prototype.specDone = function(result) {
3434
duration: new Date().getTime() - this.startTime.getTime()
3535
};
3636

37-
if (result.failedExpectations.length == 0) {
37+
if (result.failedExpectations.length === 0) {
3838
entry.assertions.push({
3939
passed: true
4040
});
@@ -93,7 +93,8 @@ exports.run = function(runner, specs) {
9393
}
9494

9595
var originalOnComplete = runner.getConfig().onComplete;
96-
jasmineNodeOpts.onComplete = function(passed) {
96+
97+
jrunner.onComplete(function(passed) {
9798
try {
9899
if (originalOnComplete) {
99100
originalOnComplete(passed);
@@ -105,7 +106,7 @@ exports.run = function(runner, specs) {
105106
} catch (err) {
106107
reject(err);
107108
}
108-
};
109+
});
109110

110111
jrunner.configureDefaultReporter(jasmineNodeOpts);
111112
jrunner.projectBaseDir = '';

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
"selenium-webdriver": "2.45.1",
1717
"minijasminenode": "1.1.1",
1818
"jasminewd": "1.1.0",
19-
"jasminewd2": "0.0.4",
20-
"jasmine": "2.1.1",
19+
"jasminewd2": "0.0.5",
20+
"jasmine": "2.3.1",
2121
"saucelabs": "~0.1.0",
2222
"glob": "~3.2",
2323
"adm-zip": "0.4.4",

0 commit comments

Comments
 (0)