fix(runner): setTestPreparer does not work

hankduan · hankduan · commit 30023f268917 · 2014-11-05T18:28:39.000-08:00
setTestPreparer would always set the testPrepare to config.onprepare during
`runner.run()`. This is breaking for code that relies on setTestPreparer
directly.
diff --git a/lib/runner.js b/lib/runner.js
@@ -44,6 +44,7 @@ var Runner = function(config) {
   }
 
   this.loadDriverProvider_(config);
+  this.setTestPreparer(config.onPrepare);
 };
 
 util.inherits(Runner, EventEmitter);
@@ -198,8 +199,6 @@ Runner.prototype.run = function() {
     throw new Error('Spec patterns did not match any files.');
   }
 
-  this.setTestPreparer(this.config_.onPrepare);
-
   var gracefulShutdown = function(driver) {
     if (driver) {
       return driver.getSession().then(function(session_) {

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ var Runner = function(config) {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`this.loadDriverProvider_(config);`
	`47`	`+ this.setTestPreparer(config.onPrepare);`
`47`	`48`	`};`
`48`	`49`
`49`	`50`	`util.inherits(Runner, EventEmitter);`
`@@ -198,8 +199,6 @@ Runner.prototype.run = function() {`
`198`	`199`	`throw new Error('Spec patterns did not match any files.');`
`199`	`200`	`}`
`200`	`201`
`201`		`- this.setTestPreparer(this.config_.onPrepare);`
`202`		`-`
`203`	`202`	`var gracefulShutdown = function(driver) {`
`204`	`203`	`if (driver) {`
`205`	`204`	`return driver.getSession().then(function(session_) {`