Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 3702a70

Browse files
bdellegrazieqiyigg
authored andcommitted
fix(local): Ensure webdriver.gecko.driver path is passed to Selenium (#4502)
Always pass webdriver.gecko.driver property to Selenium if set in local mode. fixes #4501
1 parent 1c6a1a8 commit 3702a70

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/driverProviders/local.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ import {Logger} from '../logger';
1717
import {DriverProvider} from './driverProvider';
1818

1919
const SeleniumConfig = require('webdriver-manager/built/lib/config').Config;
20-
const SeleniumChrome = require('webdriver-manager/built/lib/binaries/chrome_driver').ChromeDriver;
21-
const SeleniumStandAlone = require('webdriver-manager/built/lib/binaries/standalone').StandAlone;
2220
const remote = require('selenium-webdriver/remote');
2321

2422
let logger = new Logger('local');
@@ -151,6 +149,9 @@ export class Local extends DriverProvider {
151149
if (this.config_.chromeDriver) {
152150
serverConf.jvmArgs.push('-Dwebdriver.chrome.driver=' + this.config_.chromeDriver);
153151
}
152+
if (this.config_.geckoDriver) {
153+
serverConf.jvmArgs.push('-Dwebdriver.gecko.driver=' + this.config_.geckoDriver);
154+
}
154155

155156
this.server_ = new remote.SeleniumServer(this.config_.seleniumServerJar, serverConf);
156157

0 commit comments

Comments
 (0)