Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 4b7cada

Browse files
authored
fix(sauce): bring back sauceProxy as a configuration option (#4419)
Reverts the change to PR #3868. Protractor should connect to Sauce Labs via the sauceProxy. This is different than the webDriverProxy. The webDriverProxy is tied to the browser session where we define where the traffic will go through. closes #4405
1 parent b87159b commit 4b7cada

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

lib/config.ts

+8-3
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,14 @@ export interface Config {
9797
*/
9898
seleniumSessionId?: string;
9999
/**
100-
* The address of a proxy server to use for the connection to the
101-
* Selenium Server. If not specified no proxy is configured. Looks like
102-
* webDriverProxy: 'http://localhost:3128'
100+
* The address of a proxy server to use for communicating to Sauce Labs rest APIs via the
101+
* saucelabs node module. For example, the Sauce Labs Proxy can be setup with: sauceProxy:
102+
* 'http://localhost:3128'
103+
*/
104+
sauceProxy?: string;
105+
106+
/**
107+
* The proxy address that browser traffic will go through which is tied to the browser session.
103108
*/
104109
webDriverProxy?: string;
105110

lib/driverProviders/sauce.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export class Sauce extends DriverProvider {
5858
username: this.config_.sauceUser,
5959
password: this.config_.sauceKey,
6060
agent: this.config_.sauceAgent,
61-
proxy: this.config_.webDriverProxy
61+
proxy: this.config_.sauceProxy
6262
});
6363
this.config_.capabilities['username'] = this.config_.sauceUser;
6464
this.config_.capabilities['accessKey'] = this.config_.sauceKey;

0 commit comments

Comments
 (0)