Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 6603a7e

Browse files
committed
chore(webdriver): update selenium-webdriver to 2.40.0
1 parent b26fa7b commit 6603a7e

File tree

2 files changed

+31
-38
lines changed

2 files changed

+31
-38
lines changed

lib/locators.js

+30-37
Original file line numberDiff line numberDiff line change
@@ -32,26 +32,17 @@ util.inherits(ProtractorBy, WebdriverBy);
3232
*/
3333
ProtractorBy.prototype.addLocator = function(name, script) {
3434
this[name] = function() {
35-
var toArray = function(arguments) {
36-
var locatorArguments = [];
37-
for (var i = 0; i < arguments.length; i++) {
38-
locatorArguments.push(arguments[i]);
39-
}
40-
return locatorArguments;
41-
}
42-
var buildFindElementsArguments = function(
43-
locator, locatorArguments, scope) {
44-
var findArguments = locatorArguments.slice(0);
45-
findArguments.unshift(locator);
46-
findArguments.push(scope);
47-
return findArguments;
48-
}
49-
50-
var locatorArguments = toArray(arguments);
35+
var locatorArguments = arguments;
5136
return {
5237
findElementsOverride: function(driver, using) {
53-
return driver.findElements.apply(driver, buildFindElementsArguments(
54-
webdriver.By.js(script), locatorArguments, using));
38+
var findElementArguments = [script];
39+
for (var i = 0; i < locatorArguments.length; i++) {
40+
findElementArguments.push(locatorArguments[i]);
41+
}
42+
findElementArguments.push(using);
43+
44+
return driver.findElements(
45+
webdriver.By.js.apply(webdriver.By, findElementArguments));
5546
},
5647
message: 'by.' + name + '("' + locatorArguments + '")'
5748
};
@@ -80,8 +71,8 @@ ProtractorBy.prototype.binding = function(bindingDescriptor) {
8071
return {
8172
findElementsOverride: function(driver, using) {
8273
return driver.findElements(
83-
webdriver.By.js(clientSideScripts.findBindings),
84-
bindingDescriptor, using);
74+
webdriver.By.js(clientSideScripts.findBindings,
75+
bindingDescriptor, using));
8576
},
8677
message: 'by.binding("' + bindingDescriptor + '")'
8778
};
@@ -100,7 +91,7 @@ ProtractorBy.prototype.select = function(model) {
10091
return {
10192
findElementsOverride: function(driver, using) {
10293
return driver.findElements(
103-
webdriver.By.js(clientSideScripts.findSelects), model, using);
94+
webdriver.By.js(clientSideScripts.findSelects, model, using));
10495
},
10596
message: 'by.select("' + model + '")'
10697
};
@@ -117,7 +108,7 @@ ProtractorBy.prototype.selectedOption = function(model) {
117108
return {
118109
findElementsOverride: function(driver, using) {
119110
return driver.findElements(
120-
webdriver.By.js(clientSideScripts.findSelectedOptions), model, using);
111+
webdriver.By.js(clientSideScripts.findSelectedOptions, model, using));
121112
},
122113
message: 'by.selectedOption("' + model + '")'
123114
};
@@ -135,7 +126,7 @@ ProtractorBy.prototype.input = function(model) {
135126
return {
136127
findElementsOverride: function(driver, using) {
137128
return driver.findElements(
138-
webdriver.By.js(clientSideScripts.findInputs), model, using);
129+
webdriver.By.js(clientSideScripts.findInputs, model, using));
139130
},
140131
message: 'by.input("' + model + '")'
141132
};
@@ -159,7 +150,7 @@ ProtractorBy.prototype.model = function(model) {
159150
return {
160151
findElementsOverride: function(driver, using) {
161152
return driver.findElements(
162-
webdriver.By.js(clientSideScripts.findByModel), model, using);
153+
webdriver.By.js(clientSideScripts.findByModel, model, using));
163154
},
164155
message: 'by.model("' + model + '")'
165156
};
@@ -181,7 +172,8 @@ ProtractorBy.prototype.buttonText = function(searchText) {
181172
return {
182173
findElementsOverride: function(driver, using) {
183174
return driver.findElements(
184-
webdriver.By.js(clientSideScripts.findByButtonText), searchText, using);
175+
webdriver.By.js(clientSideScripts.findByButtonText,
176+
searchText, using));
185177
},
186178
message: 'by.buttonText("' + searchText + '")'
187179
};
@@ -203,7 +195,8 @@ ProtractorBy.prototype.partialButtonText = function(searchText) {
203195
return {
204196
findElementsOverride: function(driver, using) {
205197
return driver.findElements(
206-
webdriver.By.js(clientSideScripts.findByPartialButtonText), searchText, using);
198+
webdriver.By.js(clientSideScripts.findByPartialButtonText,
199+
searchText, using));
207200
},
208201
message: 'by.partialButtonText("' + searchText + '")'
209202
};
@@ -222,7 +215,7 @@ ProtractorBy.prototype.textarea = function(model) {
222215
return {
223216
findElementsOverride: function(driver, using) {
224217
return driver.findElements(
225-
webdriver.By.js(clientSideScripts.findTextareas), model, using);
218+
webdriver.By.js(clientSideScripts.findTextareas, model, using));
226219
},
227220
message: 'by.textarea("' + model + '")'
228221
};
@@ -257,24 +250,24 @@ ProtractorBy.prototype.repeater = function(repeatDescriptor) {
257250
return {
258251
findElementsOverride: function(driver, using) {
259252
return driver.findElements(
260-
webdriver.By.js(clientSideScripts.findAllRepeaterRows),
261-
repeatDescriptor, using);
253+
webdriver.By.js(clientSideScripts.findAllRepeaterRows,
254+
repeatDescriptor, using));
262255
},
263256
message: 'by.repeater("' + repeatDescriptor + '")',
264257
row: function(index) {
265258
return {
266259
findElementsOverride: function(driver, using) {
267260
return driver.findElements(
268-
webdriver.By.js(clientSideScripts.findRepeaterRows),
269-
repeatDescriptor, index, using);
261+
webdriver.By.js(clientSideScripts.findRepeaterRows,
262+
repeatDescriptor, index, using));
270263
},
271264
message: 'by.repeater(' + repeatDescriptor + '").row("' + index + '")"',
272265
column: function(binding) {
273266
return {
274267
findElementsOverride: function(driver, using) {
275268
return driver.findElements(
276-
webdriver.By.js(clientSideScripts.findRepeaterElement),
277-
repeatDescriptor, index, binding, using);
269+
webdriver.By.js(clientSideScripts.findRepeaterElement,
270+
repeatDescriptor, index, binding, using));
278271
},
279272
message: 'by.repeater("' + repeatDescriptor + '").row("' + index +
280273
'").column("' + binding + '")'
@@ -286,17 +279,17 @@ ProtractorBy.prototype.repeater = function(repeatDescriptor) {
286279
return {
287280
findElementsOverride: function(driver, using) {
288281
return driver.findElements(
289-
webdriver.By.js(clientSideScripts.findRepeaterColumn),
290-
repeatDescriptor, binding, using);
282+
webdriver.By.js(clientSideScripts.findRepeaterColumn,
283+
repeatDescriptor, binding, using));
291284
},
292285
message: 'by.repeater("' + repeatDescriptor + '").column("' + binding +
293286
'")',
294287
row: function(index) {
295288
return {
296289
findElementsOverride: function(driver, using) {
297290
return driver.findElements(
298-
webdriver.By.js(clientSideScripts.findRepeaterElement),
299-
repeatDescriptor, index, binding, using);
291+
webdriver.By.js(clientSideScripts.findRepeaterElement,
292+
repeatDescriptor, index, binding, using));
300293
},
301294
message: 'by.repeater("' + repeatDescriptor + '").column("' +
302295
binding + '").row("' + index + '")'

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
],
1313
"author": "Julie Ralph <[email protected]>",
1414
"dependencies": {
15-
"selenium-webdriver": "~2.39.0",
15+
"selenium-webdriver": "~2.40.0",
1616
"minijasminenode": ">=0.2.7",
1717
"saucelabs": "~0.1.0",
1818
"glob": ">=3.1.14",

0 commit comments

Comments
 (0)