chore(request): remove request module in favor of node https (#3265)

Author: cnishina

Diff for: lib/driverProviders/browserStack.ts

@@ -3,7 +3,7 @@
  * It is responsible for setting up the account object, tearing
  * it down, and setting up the driver correctly.
  */
-import * as request from 'request';
+import * as https from 'https';
 import * as q from 'q';
 import * as util from 'util';
 
@@ -23,46 +23,54 @@ export class BrowserStack extends DriverProvider {
    * @param {Object} update
    * @return {q.promise} A promise that will resolve when the update is complete.
    */
-   updateJob(update: any): q.Promise<any> {
-   let deferredArray = this.drivers_.map((driver: webdriver.WebDriver) => {
-     let deferred = q.defer();
-     driver.getSession().then((session: webdriver.Session) => {
-       var jobStatus = update.passed ? 'completed' : 'error';
-       logger.info(
-           'BrowserStack results available at ' +
-           'https://www.browserstack.com/automate');
-       request(
-           {
-             url: 'https://www.browserstack.com/automate/sessions/' +
-                 session.getId() + '.json',
-             headers: {
-               'Content-Type': 'application/json',
-               'Authorization': 'Basic ' +
-                   new Buffer(
-                       this.config_.browserstackUser + ':' +
-                       this.config_.browserstackKey)
-                       .toString('base64')
-             },
-             method: 'PUT',
-             form: {'status': jobStatus}
-           },
-           (error: Error) => {
-             if (error) {
-               throw new BrowserError(
-                   logger,
-                   'Error updating BrowserStack pass/fail status: ' +
-                       util.inspect(error));
-             }
-           });
-       deferred.resolve();
-     });
-     return deferred.promise;
-   });
-   return q.all(deferredArray);
- }
-
-
-
+  updateJob(update: any): q.Promise<any> {
+    let deferredArray = this.drivers_.map((driver: webdriver.WebDriver) => {
+      let deferred = q.defer();
+      driver.getSession().then((session: webdriver.Session) => {
+        var jobStatus = update.passed ? 'completed' : 'error';
+        logger.info(
+            'BrowserStack results available at ' +
+            'https://www.browserstack.com/automate');
+        let headers: Object = {
+            'Content-Type': 'application/json',
+            'Authorization': 'Basic ' +
+                new Buffer(
+                    this.config_.browserstackUser + ':' +
+                    this.config_.browserstackKey)
+                    .toString('base64')
+        };
+        let options = {
+          hostname: 'www.browserstack.com',
+          port: 443,
+          path: '/automate/sessions/' + session.getId() + '.json',
+          method: 'PUT',
+          headers: headers
+        };
+        https
+            .request(
+                options,
+                (res) => {
+                  let responseStr = '';
+                  res.on('data', (data: Buffer) => {
+                    responseStr += data.toString();
+                  });
+                  res.on('end', () => {
+                    logger.info(responseStr);
+                    deferred.resolve();
+                  });
+                  res.on('error', (e: Error) => {
+                    throw new BrowserError(
+                        logger,
+                        'Error updating BrowserStack pass/fail status: ' +
+                            util.inspect(e));
+                  });
+                })
+            .write('{\'status\': ' + jobStatus + '}');
+      });
+      return deferred.promise;
+    });
+    return q.all(deferredArray);
+  }
 
   /**
    * Configure and launch (if applicable) the object's environment.

Diff for: package.json

@@ -19,7 +19,6 @@
     "jasminewd2": "0.0.9",
     "optimist": "~0.6.0",
     "q": "1.4.1",
-    "request": "~2.72.0",
     "saucelabs": "~1.2.0",
     "selenium-webdriver": "2.53.2",
     "source-map-support": "~0.4.0",

Diff for: typings.json

@@ -1,14 +1,12 @@
 {
   "globalDependencies": {
     "chalk": "registry:dt/chalk#0.4.0+20160317120654",
-    "form-data": "registry:dt/form-data#0.0.0+20160316155526",
     "glob": "registry:dt/glob#5.0.10+20160317120654",
     "minimatch": "registry:dt/minimatch#2.0.8+20160317120654",
     "optimist": "registry:dt/optimist#0.0.0+20160316171810",
     "jasmine": "registry:dt/jasmine#2.2.0+20160412134438",
     "minimist": "registry:dt/minimist#1.1.3+20160317120654",
     "node": "registry:dt/node#4.0.0+20160423143914",
-    "q": "registry:dt/q#0.0.0+20160417152954",
-    "request": "registry:dt/request#0.0.0+20160316155526"
+    "q": "registry:dt/q#0.0.0+20160417152954"
   }
 }