Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 6b58e51

Browse files
committed
chore(launcher): fix jshint issues
1 parent 55a91ea commit 6b58e51

File tree

4 files changed

+23
-25
lines changed

4 files changed

+23
-25
lines changed

Diff for: lib/frameworks/cucumber.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ exports.run = function(runner, specs) {
9898
} else {
9999
callback();
100100
}
101-
}
101+
};
102102
};
103103

104104
return runner.runTestPreparer().then(function() {
@@ -108,7 +108,7 @@ exports.run = function(runner, specs) {
108108
var formatter = cucumberConf.getFormatter();
109109
addResultListener(formatter);
110110
runtime.attachListener(formatter);
111-
runtime.start(function(succeeded) {
111+
runtime.start(function() {
112112
try {
113113
if (runner.getConfig().onComplete) {
114114
runner.getConfig().onComplete();

Diff for: lib/launcher.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ var taskResults_ = {
5757
var jsonOutput = [];
5858
this.results_.forEach(function(result) {
5959
jsonOutput = jsonOutput.concat(result.specResults);
60-
})
60+
});
6161

6262
var json = JSON.stringify(jsonOutput, null, ' ');
6363
var fs = require('fs');

Diff for: lib/taskRunner.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ util.inherits(TaskRunner, EventEmitter);
3333
* taskId, specs, capabilities, failedCount, exitCode, specResults
3434
*/
3535
TaskRunner.prototype.run = function() {
36-
var self = this;
37-
3836
var runResults = {
3937
taskId: this.task.taskId,
4038
specs: this.task.specs,
@@ -43,7 +41,7 @@ TaskRunner.prototype.run = function() {
4341
failedCount: 0,
4442
exitCode: -1,
4543
specResults: []
46-
}
44+
};
4745

4846
if (this.runInFork) {
4947
var deferred = q.defer();
@@ -119,7 +117,7 @@ TaskRunner.prototype.run = function() {
119117
runner.on('testsDone', function(results) {
120118
runResults.failedCount = results.failedCount;
121119
runResults.specResults = results.specResults;
122-
})
120+
});
123121

124122
return runner.run().then(function(exitCode) {
125123
runResults.exitCode = exitCode;

Diff for: spec/unit/taskScheduler_test.js

+18-18
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe('the task scheduler', function() {
1717
var scheduler = new TaskScheduler(config);
1818

1919
var task = scheduler.nextTask();
20-
expect(task.capability.browserName).toEqual('chrome');
20+
expect(task.capabilities.browserName).toEqual('chrome');
2121
expect(task.specs.length).toEqual(2);
2222

2323
task.done();
@@ -40,11 +40,11 @@ describe('the task scheduler', function() {
4040
var scheduler = new TaskScheduler(config);
4141

4242
var task1 = scheduler.nextTask();
43-
expect(task1.capability.browserName).toEqual('chrome');
43+
expect(task1.capabilities.browserName).toEqual('chrome');
4444
expect(task1.specs.length).toEqual(1);
4545

4646
var task2 = scheduler.nextTask();
47-
expect(task2.capability.browserName).toEqual('chrome');
47+
expect(task2.capabilities.browserName).toEqual('chrome');
4848
expect(task2.specs.length).toEqual(1);
4949

5050
task1.done();
@@ -67,11 +67,11 @@ describe('the task scheduler', function() {
6767
var scheduler = new TaskScheduler(config);
6868

6969
var task1 = scheduler.nextTask();
70-
expect(task1.capability.browserName).toEqual('chrome');
70+
expect(task1.capabilities.browserName).toEqual('chrome');
7171
expect(task1.specs.length).toEqual(2);
7272

7373
var task2 = scheduler.nextTask();
74-
expect(task2.capability.browserName).toEqual('chrome');
74+
expect(task2.capabilities.browserName).toEqual('chrome');
7575
expect(task2.specs.length).toEqual(2);
7676

7777
task1.done();
@@ -95,11 +95,11 @@ describe('the task scheduler', function() {
9595
var scheduler = new TaskScheduler(config);
9696

9797
var task1 = scheduler.nextTask();
98-
expect(task1.capability.browserName).toEqual('chrome');
98+
expect(task1.capabilities.browserName).toEqual('chrome');
9999
expect(task1.specs.length).toEqual(2);
100100

101101
var task2 = scheduler.nextTask();
102-
expect(task2.capability.browserName).toEqual('firefox');
102+
expect(task2.capabilities.browserName).toEqual('firefox');
103103
expect(task2.specs.length).toEqual(2);
104104

105105
task1.done();
@@ -123,7 +123,7 @@ describe('the task scheduler', function() {
123123
var scheduler = new TaskScheduler(config);
124124

125125
var task1 = scheduler.nextTask();
126-
expect(task1.capability.browserName).toEqual('chrome');
126+
expect(task1.capabilities.browserName).toEqual('chrome');
127127
expect(task1.specs.length).toEqual(1);
128128

129129
var task2 = scheduler.nextTask();
@@ -133,7 +133,7 @@ describe('the task scheduler', function() {
133133
expect(scheduler.numTasksOutstanding()).toEqual(1);
134134

135135
var task3 = scheduler.nextTask();
136-
expect(task3.capability.browserName).toEqual('chrome');
136+
expect(task3.capabilities.browserName).toEqual('chrome');
137137
expect(task3.specs.length).toEqual(1);
138138

139139
task3.done();
@@ -155,7 +155,7 @@ describe('the task scheduler', function() {
155155
var scheduler = new TaskScheduler(config);
156156

157157
var task = scheduler.nextTask();
158-
expect(task.capability.browserName).toEqual('chrome');
158+
expect(task.capabilities.browserName).toEqual('chrome');
159159
expect(task.specs.length).toEqual(3);
160160

161161
task.done();
@@ -183,32 +183,32 @@ describe('the task scheduler', function() {
183183
var scheduler = new TaskScheduler(config);
184184

185185
var task1 = scheduler.nextTask();
186-
expect(task1.capability.browserName).toEqual('chrome');
186+
expect(task1.capabilities.browserName).toEqual('chrome');
187187
expect(task1.specs.length).toEqual(2);
188188
task1.done();
189189

190190
var task2 = scheduler.nextTask();
191-
expect(task2.capability.browserName).toEqual('chrome');
191+
expect(task2.capabilities.browserName).toEqual('chrome');
192192
expect(task2.specs.length).toEqual(2);
193193
task2.done();
194194

195195
var task3 = scheduler.nextTask();
196-
expect(task3.capability.browserName).toEqual('firefox');
196+
expect(task3.capabilities.browserName).toEqual('firefox');
197197
expect(task3.specs.length).toEqual(1);
198198
task3.done();
199199

200200
var task4 = scheduler.nextTask();
201-
expect(task4.capability.browserName).toEqual('firefox');
201+
expect(task4.capabilities.browserName).toEqual('firefox');
202202
expect(task4.specs.length).toEqual(1);
203203
task4.done();
204204

205205
var task5 = scheduler.nextTask();
206-
expect(task5.capability.browserName).toEqual('firefox');
206+
expect(task5.capabilities.browserName).toEqual('firefox');
207207
expect(task5.specs.length).toEqual(1);
208208
task5.done();
209209

210210
var task6 = scheduler.nextTask();
211-
expect(task6.capability.browserName).toEqual('firefox');
211+
expect(task6.capabilities.browserName).toEqual('firefox');
212212
expect(task6.specs.length).toEqual(1);
213213
task6.done();
214214

@@ -226,7 +226,7 @@ describe('the task scheduler', function() {
226226
var scheduler = new TaskScheduler(config);
227227

228228
var task = scheduler.nextTask();
229-
expect(task.capability.browserName).toEqual('chrome');
229+
expect(task.capabilities.browserName).toEqual('chrome');
230230
expect(task.specs.length).toEqual(2);
231231

232232
task.done();
@@ -248,7 +248,7 @@ describe('the task scheduler', function() {
248248
var scheduler = new TaskScheduler(config);
249249

250250
var task = scheduler.nextTask();
251-
expect(task.capability.browserName).toEqual('chrome');
251+
expect(task.capabilities.browserName).toEqual('chrome');
252252
expect(task.specs.length).toEqual(1);
253253

254254
task.done();

0 commit comments

Comments
 (0)