Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 8e096b9

Browse files
pkillianjuliemr
authored andcommitted
fix(Protractor.prototype.get): resolve baseUrl before ignoring synchronization
Fixes issues where setting `ignoreSynchronization = true` ignores the value of `baseUrl` entirely.
1 parent 3151ca7 commit 8e096b9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

lib/protractor.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -552,11 +552,12 @@ Protractor.prototype.clearMockModules = function() {
552552
* @param {=number} opt_timeout Number of seconds to wait for Angular to start.
553553
*/
554554
Protractor.prototype.get = function(destination, opt_timeout) {
555+
var timeout = opt_timeout || 10;
556+
destination = url.resolve(this.baseUrl, destination);
557+
555558
if (this.ignoreSynchronization) {
556559
return this.driver.get(destination);
557560
}
558-
var timeout = opt_timeout || 10;
559-
destination = url.resolve(this.baseUrl, destination);
560561

561562
this.driver.get('about:blank');
562563
this.driver.executeScript(

0 commit comments

Comments
 (0)