chore(driverProviders): add warnings to extra driver provider parameters

- builds the driver provider in lib/driverProviders/index instead of lib/runner

closes #1945

Author: cnishina

Diff for: lib/driverProviders/index.ts

@@ -6,3 +6,72 @@ export * from './hosted';
 export * from './local';
 export * from './mock';
 export * from './sauce';
+
+
+import {AttachSession} from './attachSession';
+import {BrowserStack} from './browserStack';
+import {DriverProvider} from './driverProvider';
+import {Direct} from './direct';
+import {Hosted} from './hosted';
+import {Local} from './local';
+import {Mock} from './mock';
+import {Sauce} from './sauce';
+
+import {Config} from '../config';
+import {Logger} from '../logger';
+
+let logger = new Logger('driverProviders');
+
+export let buildDriverProvider = (config: Config): DriverProvider => {
+  let driverProvider: DriverProvider;
+
+  if (config.directConnect) {
+    driverProvider = new Direct(config);
+    logWarnings('direct', config);
+  } else if (config.seleniumAddress) {
+    if (config.seleniumSessionId) {
+      driverProvider = new AttachSession(config);
+      logWarnings('attachSession', config);
+    } else {
+      driverProvider = new Hosted(config);
+      logWarnings('hosted', config);
+    }
+  } else if (config.browserstackUser && config.browserstackKey) {
+    driverProvider = new BrowserStack(config);
+    logWarnings('browserStack', config);
+  } else if (config.sauceUser && config.sauceKey) {
+    driverProvider = new Sauce(config);
+    logWarnings('sauce', config);
+  } else if (config.seleniumServerJar) {
+    driverProvider = new Local(config);
+    logWarnings('local', config);
+  } else if (config.mockSelenium) {
+    driverProvider = new Mock(config);
+    logWarnings('mock', config);
+  } else {
+    driverProvider = new Local(config);
+    logWarnings('local', config);
+  }
+  return driverProvider;
+};
+
+export let logWarnings = (providerType: string, config: Config): void => {
+
+  let warnInto = 'Using driver provider ' + providerType + ', but also found extra';
+  let warn = '';
+  warn += 'direct' !== providerType && config.directConnect ? 'directConnect: ' : '';
+  warn += 'attachSession' !== providerType && 'hosted' !== providerType && config.seleniumAddress ?
+      'seleniumAddress, ' :
+      '';
+  warn += 'attachSession' !== providerType && config.seleniumSessionId ? 'seleniumSessionId, ' : '';
+  warn += 'browserStack' !== providerType && config.browserstackUser ? 'browserstackUser, ' : '';
+  warn += 'browserStack' !== providerType && config.browserstackKey ? 'browserstackKey, ' : '';
+  warn += 'sauce' !== providerType && config.sauceUser ? 'sauceUser, ' : '';
+  warn += 'sauce' !== providerType && config.sauceKey ? 'sauceKey, ' : '';
+  warn += 'local' !== providerType && config.seleniumServerJar ? 'seleniumServerJar, ' : '';
+  warn += 'mock' !== providerType && config.mockSelenium ? 'mockSelenium, ' : '';
+  if (warn !== '') {
+    logger.warn(warnInto);
+    logger.warn('driver provider parameters: ' + warn.substring(0, warn.length - 2));
+  }
+};

Diff for: lib/runner.ts

@@ -5,7 +5,7 @@ import * as util from 'util';
 
 import {ProtractorBrowser} from './browser';
 import {Config} from './config';
-import {AttachSession, BrowserStack, Direct, DriverProvider, Hosted, Local, Mock, Sauce} from './driverProviders';
+import {buildDriverProvider, DriverProvider} from './driverProviders';
 import {Logger} from './logger';
 import {Plugins} from './plugins';
 import {protractor} from './ptor';
@@ -99,25 +99,7 @@ export class Runner extends EventEmitter {
    */
   loadDriverProvider_(config: Config) {
     this.config_ = config;
-    if (this.config_.directConnect) {
-      this.driverprovider_ = new Direct(this.config_);
-    } else if (this.config_.seleniumAddress) {
-      if (this.config_.seleniumSessionId) {
-        this.driverprovider_ = new AttachSession(this.config_);
-      } else {
-        this.driverprovider_ = new Hosted(this.config_);
-      }
-    } else if (this.config_.browserstackUser && this.config_.browserstackKey) {
-      this.driverprovider_ = new BrowserStack(this.config_);
-    } else if (this.config_.sauceUser && this.config_.sauceKey) {
-      this.driverprovider_ = new Sauce(this.config_);
-    } else if (this.config_.seleniumServerJar) {
-      this.driverprovider_ = new Local(this.config_);
-    } else if (this.config_.mockSelenium) {
-      this.driverprovider_ = new Mock(this.config_);
-    } else {
-      this.driverprovider_ = new Local(this.config_);
-    }
+    this.driverprovider_ = buildDriverProvider(this.config_);
   }
 
   /**