Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit a428a20

Browse files
cnishinajuliemr
authored andcommitted
chore(direct): fix directConnect for the last chromedriver downloaded (#3786)
1 parent e061ac0 commit a428a20

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

lib/driverProviders/direct.ts

+4-9
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import {DriverProvider} from './driverProvider';
1616
let webdriver = require('selenium-webdriver'), chrome = require('selenium-webdriver/chrome'),
1717
firefox = require('selenium-webdriver/firefox');
1818
let SeleniumConfig = require('webdriver-manager/built/lib/config').Config;
19-
let SeleniumChrome = require('webdriver-manager/built/lib/binaries/chrome_driver').ChromeDriver;
20-
let SeleniumStandAlone = require('webdriver-manager/built/lib/binaries/stand_alone').StandAlone;
2119

2220

2321
let logger = new Logger('direct');
@@ -58,15 +56,12 @@ export class Direct extends DriverProvider {
5856
*/
5957
getNewDriver(): webdriver.WebDriver {
6058
let driver: webdriver.WebDriver;
59+
let updateJson = path.resolve(SeleniumConfig.getSeleniumDir(), 'update-config.json');
60+
let updateConfig = JSON.parse(fs.readFileSync(updateJson).toString());
61+
6162
switch (this.config_.capabilities.browserName) {
6263
case 'chrome':
63-
let defaultChromeDriverPath = path.resolve(
64-
SeleniumConfig.getSeleniumDir(), new SeleniumChrome().executableFilename());
65-
66-
if (process.platform.indexOf('win') === 0) {
67-
defaultChromeDriverPath += '.exe';
68-
}
69-
64+
let defaultChromeDriverPath = updateConfig.chrome.last;
7065
let chromeDriverFile = this.config_.chromeDriver || defaultChromeDriverPath;
7166

7267
if (!fs.existsSync(chromeDriverFile)) {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"saucelabs": "~1.3.0",
2727
"selenium-webdriver": "3.0.1",
2828
"source-map-support": "~0.4.0",
29-
"webdriver-manager": "10.2.8"
29+
"webdriver-manager": "^11.0.0"
3030
},
3131
"devDependencies": {
3232
"@types/chalk": "^0.4.28",

0 commit comments

Comments
 (0)