Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit a618bfd

Browse files
committed
chore(typescript): fix imports and remove default classes (#3141)
1 parent ebbca6b commit a618bfd

File tree

6 files changed

+19
-21
lines changed

6 files changed

+19
-21
lines changed

Diff for: lib/launcher.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
'use strict';
66

77
var ConfigParser = require('./configParser').ConfigParser,
8-
TaskScheduler = require('./taskScheduler').default,
8+
TaskScheduler = require('./taskScheduler').TaskScheduler,
99
helper = require('./util'),
1010
log = require('./logger'),
1111
q = require('q'),
12-
TaskRunner = require('./taskRunner').default;
12+
TaskRunner = require('./taskRunner').TaskRunner;
1313

1414
var logPrefix = '[launcher]';
1515
var RUNNERS_FAILED_EXIT_CODE = 100;

Diff for: lib/plugins.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var webdriver = require('selenium-webdriver'),
22
q = require('q'),
3-
ConfigParser = require('./configParser').default,
3+
ConfigParser = require('./configParser').ConfigParser,
44
log = require('./logger');
55

66
var PROMISE_TYPE = {

Diff for: lib/taskLogger.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import {EOL} from 'os';
1+
import * as os from 'os';
22
import * as Logger from './logger';
33

4-
export default class TaskLogger {
4+
export class TaskLogger {
55
private buffer: string = '';
66
private insertTag: boolean = true;
77

@@ -22,9 +22,9 @@ export default class TaskLogger {
2222
* @private
2323
*/
2424
private logHeader_(): void {
25-
let output = 'PID: ' + this.pid + EOL;
25+
let output = 'PID: ' + this.pid + os.EOL;
2626
if (this.task.specs.length === 1) {
27-
output += 'Specs: ' + this.task.specs.toString() + EOL + EOL;
27+
output += 'Specs: ' + this.task.specs.toString() + os.EOL + os.EOL;
2828
}
2929
this.log(output);
3030
}
@@ -35,9 +35,9 @@ export default class TaskLogger {
3535
public flush(): void {
3636
if (this.buffer) {
3737
// Flush buffer if nonempty
38-
Logger.print(EOL + '------------------------------------' + EOL);
38+
Logger.print(os.EOL + '------------------------------------' + os.EOL);
3939
Logger.print(this.buffer);
40-
Logger.print(EOL);
40+
Logger.print(os.EOL);
4141
this.buffer = '';
4242
}
4343
}

Diff for: lib/taskRunner.ts

+7-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
import {fork} from 'child_process';
1+
import * as child_process from 'child_process';
22
import {EventEmitter} from 'events';
3-
import {defer, Promise} from 'q';
4-
import {inherits} from 'util';
3+
import * as q from 'q';
54

65
import {ConfigParser, Config} from './configParser';
76
import * as Logger from './logger';
8-
import TaskLogger from './taskLogger';
7+
import {TaskLogger} from './taskLogger';
98

109
export interface RunResults {
1110
taskId: number;
@@ -16,7 +15,7 @@ export interface RunResults {
1615
specResults: Array<any>;
1716
}
1817

19-
export default class TaskRunner extends EventEmitter {
18+
export class TaskRunner extends EventEmitter {
2019
/**
2120
* A runner for running a specified task (capabilities + specs).
2221
* The TaskRunner can either run the task from the current process (via
@@ -42,7 +41,7 @@ export default class TaskRunner extends EventEmitter {
4241
* result of the run:
4342
* taskId, specs, capabilities, failedCount, exitCode, specResults
4443
*/
45-
public run(): Promise<any> {
44+
public run(): q.Promise<any> {
4645
let runResults: RunResults = {
4746
taskId: this.task.taskId,
4847
specs: this.task.specs,
@@ -54,9 +53,9 @@ export default class TaskRunner extends EventEmitter {
5453
};
5554

5655
if (this.runInFork) {
57-
let deferred = defer();
56+
let deferred = q.defer();
5857

59-
let childProcess = fork(
58+
let childProcess = child_process.fork(
6059
__dirname + '/runnerCli.js', process.argv.slice(2),
6160
{cwd: process.cwd(), silent: true});
6261
let taskLogger = new TaskLogger(this.task, childProcess.pid);

Diff for: lib/taskScheduler.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import {ConfigParser, Config} from './configParser';
22

3-
43
export interface Task {
54
capabilities: any;
65
specs: Array<string>;
@@ -23,7 +22,7 @@ export class TaskQueue {
2322
}
2423
}
2524

26-
export default class TaskScheduler {
25+
export class TaskScheduler {
2726
taskQueues: Array<TaskQueue>;
2827
rotationIndex: number;
2928

Diff for: spec/unit/taskScheduler_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
var TaskScheduler = require('../../built/taskScheduler').default;
2-
var ConfigParser = require('../../built/configParser').default;
1+
var TaskScheduler = require('../../built/taskScheduler').TaskScheduler;
2+
var ConfigParser = require('../../built/configParser').ConfigParser;
33

44
describe('the task scheduler', function() {
55

0 commit comments

Comments
 (0)