Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit c6ec28b

Browse files
committed
clean comments
1 parent a8a0888 commit c6ec28b

File tree

5 files changed

+3
-8
lines changed

5 files changed

+3
-8
lines changed

Diff for: lib/browser.ts

-1
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,6 @@ export class ProtractorBrowser extends AbstractExtendedWebDriver {
489489
script = 'return (' + script + ').apply(null, arguments);';
490490
}
491491

492-
// TODO(selenium4): fix promise cast.
493492
// TODO(selenium4): schedule does not exist on driver. Should use execute instead.
494493
return (this.driver as any)
495494
.execute(new Command(CommandName.EXECUTE_SCRIPT)

Diff for: lib/driverProviders/attachSession.ts

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export class AttachSession extends DriverProvider {
4040
const executor = new http.Executor(httpClient);
4141
const session = new Session(this.config_.seleniumSessionId, null);
4242

43-
// const newDriver = WebDriver.attachToSession(executor, this.config_.seleniumSessionId, null);
4443
const newDriver = new WebDriver(session, executor);
4544
this.drivers_.push(newDriver);
4645
return newDriver;

Diff for: lib/launcher.ts

-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ let initFn = async function(configFile: string, additionalConfig: Config) {
171171
});
172172

173173
process.on('unhandledRejection', (reason: Error | any, p: Promise<any>) => {
174-
// let e = new Error();
175174
if (reason.stack.match('angular testability are undefined') ||
176175
reason.stack.match('angular is not defined')) {
177176
logger.warn(

Diff for: lib/runner.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,8 @@ export class Runner extends EventEmitter {
256256
}
257257

258258
await browser_.waitForAngularEnabled(initProperties.waitForAngularEnabled);
259-
await driver.manage().timeouts().setScriptTimeout(initProperties.allScriptsTimeout || 0);
259+
// TODO(selenium4): Options does not have a setScriptTimeout method.
260+
await(driver.manage() as any).setScriptTimeout(initProperties.allScriptsTimeout || 0);
260261

261262
browser_.getProcessedConfig = () => {
262263
return Promise.resolve(config);

Diff for: scripts/test.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,7 @@ const passingTests = [
5050
// Dependency tests
5151
'node node_modules/jasmine/bin/jasmine.js JASMINE_CONFIG_PATH=scripts/dependency_test.json',
5252
// Typings tests
53-
<<<<<<< HEAD
54-
=======
55-
// TODO(selenium4): not sure why this does not work.
56-
>>>>>>> deps(selenium): upgrade to selenium 4
53+
// TODO(selenium4): consider rewriting this test.
5754
// 'node spec/install/test.js'
5855
];
5956

0 commit comments

Comments
 (0)