Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit c76b26a

Browse files
cnishinajuliemr
authored andcommitted
chore(direct): fix directConnect for the last chromedriver downloaded (#3786)
1 parent f774ef8 commit c76b26a

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

lib/driverProviders/direct.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import {Logger} from '../logger';
1717
import {DriverProvider} from './driverProvider';
1818

1919
const SeleniumConfig = require('webdriver-manager/built/lib/config').Config;
20-
const SeleniumChrome = require('webdriver-manager/built/lib/binaries/chrome_driver').ChromeDriver;
2120

2221
let logger = new Logger('direct');
2322
export class Direct extends DriverProvider {
@@ -57,15 +56,12 @@ export class Direct extends DriverProvider {
5756
*/
5857
getNewDriver(): WebDriver {
5958
let driver: WebDriver;
59+
let updateJson = path.resolve(SeleniumConfig.getSeleniumDir(), 'update-config.json');
60+
let updateConfig = JSON.parse(fs.readFileSync(updateJson).toString());
61+
6062
switch (this.config_.capabilities.browserName) {
6163
case 'chrome':
62-
let defaultChromeDriverPath = path.resolve(
63-
SeleniumConfig.getSeleniumDir(), new SeleniumChrome().executableFilename());
64-
65-
if (process.platform.indexOf('win') === 0) {
66-
defaultChromeDriverPath += '.exe';
67-
}
68-
64+
let defaultChromeDriverPath = updateConfig.chrome.last;
6965
let chromeDriverFile = this.config_.chromeDriver || defaultChromeDriverPath;
7066

7167
if (!fs.existsSync(chromeDriverFile)) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"saucelabs": "~1.3.0",
2727
"selenium-webdriver": "3.0.1",
2828
"source-map-support": "~0.4.0",
29-
"webdriver-manager": "^10.3.0"
29+
"webdriver-manager": "^11.0.0"
3030
},
3131
"devDependencies": {
3232
"@types/chalk": "^0.4.28",

0 commit comments

Comments
 (0)