Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit c8c85e0

Browse files
committed
fix(locators): fix by.repeater finding all rows for IE
Previously, element.all(by.repeater('foo in foos')) would find non-element nodes for ng-repeat-start elements, which could cause IEDriver to fall over if the test tried to get text from those nodes.
1 parent b01ea83 commit c8c85e0

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

lib/clientsidescripts.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ clientSideScripts.findBindings = function(binding, exactMatch, using) {
150150
var elem = repeatElems[i];
151151
while (elem.nodeType != 8 ||
152152
elem.nodeValue.indexOf(repeater) == -1) {
153-
rows.push(elem);
153+
if (elem.nodeType == 1) {
154+
rows.push(elem);
155+
}
154156
elem = elem.nextSibling;
155157
}
156158
}

0 commit comments

Comments
 (0)