Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit d44ef01

Browse files
committed
feat(debugging): remove webdriver lines from stacktraces by default to improve readability
1 parent 643ca50 commit d44ef01

File tree

3 files changed

+26
-2
lines changed

3 files changed

+26
-2
lines changed

lib/protractor.js

+23
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var url = require('url');
22
var util = require('util');
3+
var path = require('path');
34
var webdriver = require('selenium-webdriver');
45

56
var clientSideScripts = require('./clientsidescripts.js');
@@ -658,3 +659,25 @@ exports.setInstance = function(ptor) {
658659
exports.getInstance = function() {
659660
return instance;
660661
}
662+
663+
/**
664+
* Utility function that filters a stack trace to be more readable. It removes
665+
* Jasmine test frames and webdriver promise resolution.
666+
* @param {string} text Original stack trace.
667+
* @return {string}
668+
*/
669+
exports.filterStackTrace = function(text) {
670+
if (!text) {
671+
return text;
672+
}
673+
var jasmineFilename = 'node_modules/minijasminenode/lib/jasmine-1.3.1.js';
674+
var seleniumFilename = 'node_modules/selenium-webdriver';
675+
var lines = [];
676+
text.split(/\n/).forEach(function(line){
677+
if (line.indexOf(jasmineFilename) == -1 &&
678+
line.indexOf(seleniumFilename) == -1) {
679+
lines.push(line);
680+
}
681+
});
682+
return lines.join('\n');
683+
}

lib/runner.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ var config = {
3131
jasmineNodeOpts: {
3232
isVerbose: false,
3333
showColors: true,
34-
includeStackTrace: true
34+
includeStackTrace: true,
35+
stackFilter: protractor.filterStackTrace
3536
}
3637
}
3738

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Julie Ralph <[email protected]>",
1414
"dependencies": {
1515
"selenium-webdriver": "~2.37.0",
16-
"minijasminenode": "~0.2.6",
16+
"minijasminenode": ">=0.2.7",
1717
"saucelabs": "~0.1.0",
1818
"glob": ">=3.1.14",
1919
"adm-zip": ">=0.4.2",

0 commit comments

Comments
 (0)