Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit d777738

Browse files
authored
chore(tests): circleci - chrome 69 requires chromdriver to 2.44 (#5182)
- Move circle.yml file to .circleci/config.yml to satisfy circleci warnings (version 1.0 deprecation). - The browser in circle is version 69. The browser requires chromedriver 2.44.
1 parent 3d50b68 commit d777738

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Diff for: circle.yml renamed to .circleci/config.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ jobs:
5454
name: Selenium Start
5555
background: true
5656
command: |
57-
./node_modules/.bin/webdriver-manager update
58-
./node_modules/.bin/webdriver-manager start
57+
./node_modules/.bin/webdriver-manager update --versions.chrome=2.44
58+
./node_modules/.bin/webdriver-manager start --versions.chrome=2.44
5959
6060
- run:
6161
name: TestApp Start

Diff for: gulpfile.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ gulp.task('tslint', () => {
4040

4141
gulp.task('format:enforce', () => {
4242
return gulp.src(['lib/**/*.ts'])
43-
.pipe(format.checkFormat('file', clangFormat, {verbose: true, fail: true}));
43+
.pipe(format.checkFormat('file', clangFormat,
44+
{verbose: true, fail: true}));
4445
});
4546

4647
gulp.task('lint', gulp.series('tslint', 'format:enforce'));
@@ -71,7 +72,8 @@ gulp.task('built:copy:typings', () => {
7172
});
7273

7374
gulp.task('webdriver:update', (done) => {
74-
runSpawn(done, 'node', ['bin/webdriver-manager', 'update']);
75+
runSpawn(done, 'node', ['bin/webdriver-manager', 'update',
76+
'--versions.chrome=2.44']);
7577
});
7678

7779
gulp.task('format', () => {

0 commit comments

Comments
 (0)