fix(launcher): Handle uncaught exceptions that are strings. (#3506)

Also clean up instances where we were throwing strings instead of Errors.

Author: heathkit

lib/browser.ts

@@ -448,8 +448,9 @@ export class ProtractorBrowser extends Webdriver {
     return runWaitForAngularScript()
         .then((browserErr: Function) => {
           if (browserErr) {
-            throw 'Error while waiting for Protractor to ' +
-                'sync with the page: ' + JSON.stringify(browserErr);
+            throw new Error(
+                'Error while waiting for Protractor to ' +
+                'sync with the page: ' + JSON.stringify(browserErr));
           }
         })
         .then(
@@ -790,7 +791,8 @@ export class ProtractorBrowser extends Webdriver {
               return angularVersion;
             },
             (err: Error) => {
-              throw 'Error while running testForAngular: ' + err.message;
+              throw new Error(
+                  'Error while running testForAngular: ' + err.message);
             })
         .then(loadMocks, deferred.reject);
 
@@ -812,8 +814,9 @@ export class ProtractorBrowser extends Webdriver {
               .then(
                   null,
                   (err: Error) => {
-                    throw 'Error while running module script ' + name + ': ' +
-                        err.message;
+                    throw new Error(
+                        'Error while running module script ' + name + ': ' +
+                        err.message);
                   })
               .then(null, deferred.reject);
         }

lib/cli.ts

@@ -72,7 +72,7 @@ optimist
     .string('capabilities.tunnel-identifier')
     .check(function(arg: any) {
       if (arg._.length > 1) {
-        throw 'Error: more than one config file specified';
+        throw new Error('Error: more than one config file specified');
       }
     });
 

lib/exitCodes.ts

@@ -85,7 +85,7 @@ export class ErrorHandler {
     if (errMsgs && errMsgs.length > 0) {
       for (let errPos in errMsgs) {
         let errMsg = errMsgs[errPos];
-        if (e.message.indexOf(errMsg) !== -1) {
+        if (e.message && e.message.indexOf(errMsg) !== -1) {
           return true;
         }
       }

lib/launcher.ts

@@ -179,7 +179,9 @@ let initFn = function(configFile: string, additionalConfig: Config) {
         // 4) Run tests.
         let scheduler = new TaskScheduler(config);
 
-        process.on('uncaughtException', (e: Error) => {
+        process.on('uncaughtException', (exc: (Error|string)) => {
+          let e = (exc instanceof Error) ? exc : new Error(exc);
+
           let errorCode = ErrorHandler.parseError(e);
           if (errorCode) {
             let protractorError = e as ProtractorError;