Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

by.exactBinding not working due to regular expression typo #1441

Closed
graffic opened this issue Oct 15, 2014 · 2 comments
Closed

by.exactBinding not working due to regular expression typo #1441

graffic opened this issue Oct 15, 2014 · 2 comments

Comments

@graffic
Copy link

graffic commented Oct 15, 2014

In the client side script for findBindings, in the regular expression where the code matches if is an exact match or not the end and beggining markers for regular expressions: $ and ^ are switched.

https://github.com/angular/protractor/blob/1.3.1/lib/clientsidescripts.js#L66

'({|\\s|$|\\|)' + binding + '(}|\\s|^|\\|)')

I guess it should be: '({|\\s|^|\\|)' + binding + '(}|\\s|$|\\|)')

@juliemr
Copy link
Member

juliemr commented Oct 15, 2014

Well, that's embarrassing. Yes, this was masked before due to {{}} being kept with the binding name.

@hankduan
Copy link
Contributor

Thanks for bringing this up! fixed now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants