add a test that uses a namespace-qualified interface

Summary:
Extend the namespace-qualifying-types test to also test
an imported interface.

Fix one minor bug it revealed (the Closure-side "function Foo()"
generated from a "interface Foo" must also be exported if the
interface is exported.)

More work on #112.

Reviewers: rkirov

Reviewed By: rkirov

Differential Revision: https://reviews.angular.io/D126

Author: evmar

src/tsickle.ts

@@ -461,18 +461,23 @@ class Annotator extends Rewriter {
   private emitInterface(iface: ts.InterfaceDeclaration) {
     if (this.options.untyped) return;
     this.emit(`\n/** @record */\n`);
-    this.emit(`function ${getIdentifierText(iface.name)}() {}\n`);
+    let name = getIdentifierText(iface.name);
+    this.emit(`function ${name}() {}\n`);
     if (iface.typeParameters) {
       this.emit(`// TODO: type parameters.\n`);
     }
     if (iface.heritageClauses) {
       this.emit(`// TODO: derived interfaces.\n`);
     }
 
-    const memberNamespace = [getIdentifierText(iface.name), 'prototype'];
+    const memberNamespace = [name, 'prototype'];
     for (let elem of iface.members) {
       this.visitProperty(memberNamespace, elem);
     }
+
+    if (iface.flags & ts.NodeFlags.Export) {
+      this.emit(`export {${name}};\n`);
+    }
   }
 
   // emitTypeAnnotationsHelper produces a

test_files/export/export_helper.js

@@ -7,6 +7,7 @@ exports.export1 = 3;
 exports.export2 = 3;
 /** @record */
 function Bar() { }
+exports.Bar = Bar;
 /** @type {number} */
 Bar.prototype.barField;
 exports.export3 = null;

test_files/export/export_helper.tsickle.ts

@@ -7,6 +7,7 @@ export let /** @type {number} */ export2 = 3;
 function Bar() {}
  /** @type {number} */
 Bar.prototype.barField;
+export {Bar};
 
 
 export interface Bar { barField: number; }

test_files/jsdoc_types/jsdoc_types.js

@@ -6,3 +6,4 @@ goog.module('tsickle_test.jsdoc_types.jsdoc_types');/**
 var module1 = goog.require('tsickle_test.jsdoc_types.module1');
 // Check that imported types get the proper names in JSDoc.
 let /** @type {module1.Class} */ x1 = new module1.Class();
+let /** @type {module1.Interface} */ x2 = null;

test_files/jsdoc_types/jsdoc_types.ts

@@ -7,3 +7,4 @@ import * as module1 from './module1';
 
 // Check that imported types get the proper names in JSDoc.
 let x1 = new module1.Class();
+let x2: module1.Interface = null;

test_files/jsdoc_types/jsdoc_types.tsickle.ts

@@ -7,3 +7,4 @@ import * as module1 from './module1';
 
 // Check that imported types get the proper names in JSDoc.
 let /** @type {module1.Class} */ x1 = new module1.Class();
+let /** @type {module1.Interface} */ x2: module1.Interface = null;

test_files/jsdoc_types/module1.js

@@ -2,3 +2,8 @@ goog.module('tsickle_test.jsdoc_types.module1');
 class Class {
 }
 exports.Class = Class;
+/** @record */
+function Interface() { }
+exports.Interface = Interface;
+/** @type {number} */
+Interface.prototype.x;

test_files/jsdoc_types/module1.ts

@@ -1 +1,2 @@
 export class Class {}
+export interface Interface { x: number }

test_files/jsdoc_types/module1.tsickle.ts

@@ -1 +1,8 @@
 export class Class {}
+/** @record */
+function Interface() {}
+ /** @type {number} */
+Interface.prototype.x;
+export {Interface};
+
+export interface Interface { x: number }