build: upgrade to typescript 3.2.2

Author: JiaLiPassion

lib/common/fetch.ts

@@ -7,6 +7,9 @@
  */
 
 Zone.__load_patch('fetch', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
+  interface FetchTaskData extends TaskData {
+    fetchArgs?: any[];
+  }
   let fetch = global['fetch'];
   if (typeof fetch !== 'function') {
     return;
@@ -46,7 +49,7 @@ Zone.__load_patch('fetch', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
     const signal = options && options.signal;
     return new Promise((res, rej) => {
       const task = Zone.current.scheduleMacroTask(
-          'fetch', placeholder, args,
+          'fetch', placeholder, {fetchArgs: args} as FetchTaskData,
           () => {
             let fetchPromise;
             let zone = Zone.current;

lib/common/to-string.ts

@@ -21,25 +21,25 @@ Zone.__load_patch('toString', (global: any) => {
       const originalDelegate = this[ORIGINAL_DELEGATE_SYMBOL];
       if (originalDelegate) {
         if (typeof originalDelegate === 'function') {
-          return originalFunctionToString.apply(this[ORIGINAL_DELEGATE_SYMBOL], arguments);
+          return originalFunctionToString.call(originalDelegate);
         } else {
           return Object.prototype.toString.call(originalDelegate);
         }
       }
       if (this === Promise) {
         const nativePromise = global[PROMISE_SYMBOL];
         if (nativePromise) {
-          return originalFunctionToString.apply(nativePromise, arguments);
+          return originalFunctionToString.call(nativePromise);
         }
       }
       if (this === Error) {
         const nativeError = global[ERROR_SYMBOL];
         if (nativeError) {
-          return originalFunctionToString.apply(nativeError, arguments);
+          return originalFunctionToString.call(nativeError);
         }
       }
     }
-    return originalFunctionToString.apply(this, arguments);
+    return originalFunctionToString.call(this);
   };
   (newFunctionToString as any)[ORIGINAL_DELEGATE_SYMBOL] = originalFunctionToString;
   Function.prototype.toString = newFunctionToString;
@@ -52,6 +52,6 @@ Zone.__load_patch('toString', (global: any) => {
     if (this instanceof Promise) {
       return PROMISE_OBJECT_TO_STRING;
     }
-    return originalObjectToString.apply(this, arguments);
+    return originalObjectToString.call(this);
   };
 });

lib/common/utils.ts

@@ -57,7 +57,7 @@ const internalWindow: any = isWindowExists ? window : undefined;
 const _global: any = isWindowExists && internalWindow || typeof self === 'object' && self || global;
 
 const REMOVE_ATTRIBUTE = 'removeAttribute';
-const NULL_ON_PROP_VALUE: any[] = [null];
+const NULL_ON_PROP_VALUE: [any] = [null];
 
 export function bindArguments(args: any[], source: string): any[] {
   for (let i = args.length - 1; i >= 0; i--) {

lib/jasmine/jasmine.ts

@@ -188,26 +188,21 @@
   }
   interface QueueRunnerAttrs {
     queueableFns: {fn: Function}[];
-    onComplete: () => void;
     clearStack: (fn: any) => void;
-    onException: (error: any) => void;
     catchException: () => boolean;
+    fail: () => void;
+    onComplete: () => void;
+    onException: (error: any) => void;
     userContext: any;
     timeout: {setTimeout: Function; clearTimeout: Function};
-    fail: () => void;
   }
 
   const QueueRunner = (jasmine as any).QueueRunner as {
     new (attrs: QueueRunnerAttrs): QueueRunner;
   };
   (jasmine as any).QueueRunner = (function(_super) {
     __extends(ZoneQueueRunner, _super);
-    function ZoneQueueRunner(attrs: {
-      onComplete: Function;
-      userContext?: any;
-      timeout?: {setTimeout: Function; clearTimeout: Function};
-      onException?: (error: any) => void;
-    }) {
+    function ZoneQueueRunner(attrs: QueueRunnerAttrs) {
       attrs.onComplete = (fn => () => {
         // All functions are done, clear the test zone.
         this.testProxyZone = null;

lib/rxjs/rxjs-fake-async.ts

@@ -10,12 +10,12 @@ import {asapScheduler, asyncScheduler, Scheduler} from 'rxjs';
 
 Zone.__load_patch('rxjs.Scheduler.now', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
   api.patchMethod(Scheduler, 'now', (delegate: Function) => (self: any, args: any[]) => {
-    return Date.now.apply(self, args);
+    return Date.now.call(self);
   });
   api.patchMethod(asyncScheduler, 'now', (delegate: Function) => (self: any, args: any[]) => {
-    return Date.now.apply(self, args);
+    return Date.now.call(self);
   });
   api.patchMethod(asapScheduler, 'now', (delegate: Function) => (self: any, args: any[]) => {
-    return Date.now.apply(self, args);
+    return Date.now.call(self);
   });
 });

lib/rxjs/rxjs.ts

@@ -145,26 +145,28 @@ import {Observable, Subscriber, Subscription} from 'rxjs';
     Subscriber.prototype.next = function() {
       const currentZone = Zone.current;
       const subscriptionZone = this._zone;
+      const args: [any?] = Array.prototype.slice.call(arguments) as [any?];
 
       // for performance concern, check Zone.current
       // equal with this._zone(SubscriptionZone) or not
       if (subscriptionZone && subscriptionZone !== currentZone) {
         return subscriptionZone.run(next, this, arguments, nextSource);
       } else {
-        return next.apply(this, arguments);
+        return next.apply(this, args);
       }
     };
 
     Subscriber.prototype.error = function() {
       const currentZone = Zone.current;
       const subscriptionZone = this._zone;
+      const args: [any?] = Array.prototype.slice.call(arguments) as [any?];
 
       // for performance concern, check Zone.current
       // equal with this._zone(SubscriptionZone) or not
       if (subscriptionZone && subscriptionZone !== currentZone) {
         return subscriptionZone.run(error, this, arguments, errorSource);
       } else {
-        return error.apply(this, arguments);
+        return error.apply(this, args);
       }
     };
 
@@ -177,7 +179,7 @@ import {Observable, Subscriber, Subscription} from 'rxjs';
       if (subscriptionZone && subscriptionZone !== currentZone) {
         return subscriptionZone.run(complete, this, arguments, completeSource);
       } else {
-        return complete.apply(this, arguments);
+        return complete.call(this);
       }
     };
   };

package.json

@@ -106,7 +106,7 @@
     "ts-loader": "^0.6.0",
     "tslint": "^4.1.1",
     "tslint-eslint-rules": "^3.1.0",
-    "typescript": "^3.0.3",
+    "typescript": "^3.2.2",
     "vrsource-tslint-rules": "^4.0.0",
     "webdriver-manager": "^12.0.6",
     "webdriverio": "^4.8.0",

test/browser/XMLHttpRequest.spec.ts

@@ -386,7 +386,7 @@ describe('XMLHttpRequest', function() {
          };
          expect(req.onreadystatechange).toBe(listener);
          req.onreadystatechange = function() {
-           return listener.apply(this, arguments);
+           return listener.call(this);
          };
          req.send();
        });

test/common/Promise.spec.ts

@@ -103,7 +103,7 @@ describe(
 
       xit('should ensure that Promise this is instanceof Promise', () => {
         expect(() => {
-          Promise.call({}, null);
+          Promise.call({}, () => null);
         }).toThrowError('Must be an instanceof Promise.');
       });
 
@@ -488,18 +488,22 @@ describe(
       });
 
       describe('Promise subclasses', function() {
-        class MyPromise {
+        class MyPromise<T> {
           private _promise: Promise<any>;
           constructor(init: any) {
             this._promise = new Promise(init);
           }
 
-          catch() {
-            return this._promise.catch.apply(this._promise, arguments);
+          catch<TResult = never>(onrejected?: ((reason: any) => TResult | PromiseLike<TResult>)|
+                                 undefined|null): Promise<T|TResult> {
+            return this._promise.catch.call(this._promise, onrejected);
           };
 
-          then() {
-            return this._promise.then.apply(this._promise, arguments);
+          then<TResult1 = T, TResult2 = never>(
+              onfulfilled?: ((value: T) => TResult1 | PromiseLike<TResult1>)|undefined|null,
+              onrejected?: ((reason: any) => TResult2 | PromiseLike<TResult2>)|undefined|
+              null): Promise<any> {
+            return this._promise.then.call(this._promise, onfulfilled, onrejected);
           };
         }
 

yarn.lock

@@ -6472,10 +6472,10 @@ typedarray@^0.0.6, typedarray@~0.0.5:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@^3.0.3:
-  version "3.0.3"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.0.3.tgz#4853b3e275ecdaa27f78fda46dc273a7eb7fc1c8"
-  integrity sha512-kk80vLW9iGtjMnIv11qyxLqZm20UklzuR2tL0QAnDIygIUIemcZMxlMWudl9OOt76H3ntVzcTiddQ1/pAAJMYg==
+typescript@^3.2.2:
+  version "3.3.3333"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.3.3333.tgz#171b2c5af66c59e9431199117a3bcadc66fdcfd6"
+  integrity sha512-JjSKsAfuHBE/fB2oZ8NxtRTk5iGcg6hkYXMnZ3Wc+b2RSqejEqTaem11mHASMnFilHrax3sLK0GDzcJrekZYLw==
 
 [email protected]:
   version "2.6.4"