fix(core): add comment for shorter var/function name

Author: JiaLiPassion

Diff for: lib/browser/browser.ts

@@ -45,6 +45,7 @@ import {registerElementPatch} from './register-element';
     const name = blockingMethods[i];
     patchMethod(global, name, (delegate, symbol, name) => {
       return function(s: any, args: any[]) {
+        // Zone.current.run
         return (Zone as any).c.r(delegate, global, args, name);
       };
     });
@@ -53,6 +54,7 @@ import {registerElementPatch} from './register-element';
 
 (Zone as any).l('EventTarget', (global: any, Zone: ZoneType, api: _ZonePrivate) => {
   // load blackListEvents from global
+  // Zone.__symbol__
   const SYMBOL_BLACK_LISTED_EVENTS = (Zone as any).s('BLACK_LISTED_EVENTS');
   if (global[SYMBOL_BLACK_LISTED_EVENTS]) {
     (Zone as any)[SYMBOL_BLACK_LISTED_EVENTS] = global[SYMBOL_BLACK_LISTED_EVENTS];
@@ -79,6 +81,7 @@ import {registerElementPatch} from './register-element';
 
 (Zone as any).l('canvas', (global: any) => {
   const HTMLCanvasElement = global['HTMLCanvasElement'];
+  // o is 'undefined'
   if (typeof HTMLCanvasElement !== o && HTMLCanvasElement.prototype &&
       HTMLCanvasElement.prototype.toBlob) {
     patchMacroTask(HTMLCanvasElement.prototype, 'toBlob', (self: any, args: any[]) => {
@@ -133,6 +136,8 @@ import {registerElementPatch} from './register-element';
       // remove existing event listener
       const listener = target[XHR_LISTENER];
       if (!oriAddListener) {
+        // i is addEventListener zoneSymbol
+        // j is removeEventListener zoneSymbol
         oriAddListener = target[i];
         oriRemoveListener = target[j];
       }
@@ -180,6 +185,7 @@ import {registerElementPatch} from './register-element';
     const XMLHTTPREQUEST_SOURCE = 'XMLHttpRequest.send';
     const sendNative: Function =
         patchMethod(XMLHttpRequestPrototype, 'send', () => function(self: any, args: any[]) {
+          // Zone.current
           const zone = (Zone as any).c;
           if (self[XHR_SYNC]) {
             // if the XHR is sync there is no task to schedule, just execute the code.
@@ -193,13 +199,15 @@ import {registerElementPatch} from './register-element';
               args: args,
               aborted: false
             };
+            // Zone.scheduleMacroTask
             return zone.sc(
                 XMLHTTPREQUEST_SOURCE, placeholderCallback, options, scheduleTask, clearTask);
           }
         });
 
     const abortNative = patchMethod(XMLHttpRequestPrototype, 'abort', () => function(self: any) {
       const task: Task = findPendingTask(self);
+      // r is 'string'
       if (task && typeof task.type == r) {
         // If the XHR has already completed, do nothing.
         // If the XHR has already been aborted, do nothing.
@@ -208,6 +216,7 @@ import {registerElementPatch} from './register-element';
         if (task.cancelFn == null || (task.data && (<XHROptions>task.data).aborted)) {
           return;
         }
+        // Zone.cancelTask
         (task.zone as any).ct(task);
       }
       // Otherwise, we are trying to abort an XHR which has not yet been sent, so there is no

Diff for: lib/browser/define-property.ts

@@ -38,6 +38,7 @@ export function propertyPatch() {
   };
 
   Object.create = <any>function(obj: any, proto: any) {
+    // o is 'object' string
     if (typeof proto === p && !Object.isFrozen(proto)) {
       Object.keys(proto).forEach(function(prop) {
         proto[prop] = rewriteDescriptor(obj, prop, proto[prop]);
@@ -89,6 +90,7 @@ function _tryDefineProperty(obj: any, prop: string, desc: any, originalConfigura
     if (desc.configurable) {
       // In case of errors, when the configurable flag was likely set by rewriteDescriptor(), let's
       // retry with the original flag value
+      // o is 'undefined' string
       if (typeof originalConfigurableFlag == o) {
         delete desc.configurable;
       } else {

Diff for: lib/browser/event-target.ts

@@ -45,18 +45,26 @@ export function eventTargetPatch(_global: any, api: _ZonePrivate) {
   //  predefine all __zone_symbol__ + eventName + true/false string
   for (let i = 0; i < eventNames.length; i++) {
     const eventName = eventNames[i];
+    // l is 'false' string
     const falseEventName = eventName + l;
+    // k is 'true' string
     const trueEventName = eventName + k;
+    // m is '__zone_symbol__' string
     const symbol = m + falseEventName;
+    // m is '__zone_symbol__' string
     const symbolCapture = m + trueEventName;
+    // ens is globalEventNames cache
     ens[eventName] = {};
+    // l is 'false' string
     ens[eventName][l] = symbol;
+    // k is 'true' string
     ens[eventName][k] = symbolCapture;
   }
 
   //  predefine all task.source string
   for (let i = 0; i < WTF_ISSUE_555.length; i++) {
     const target: any = WTF_ISSUE_555_ARRAY[i];
+    // gs is global source cache
     const targets: any = gs[target] = {};
     for (let j = 0; j < eventNames.length; j++) {
       const eventName = eventNames[j];
@@ -101,6 +109,8 @@ export function eventTargetPatch(_global: any, api: _ZonePrivate) {
     const type = _global[apis[i]];
     apiTypes.push(type && type.prototype);
   }
+  // vh is validateHandler to check event handler
+  // is valid or not(for security check)
   patchEventTarget(_global, apiTypes, {vh: checkIEAndCrossContext});
   api.patchEventTarget = patchEventTarget;
 

Diff for: lib/browser/property-descriptor.ts

@@ -265,6 +265,7 @@ export function propertyDescriptorPatch(api: _ZonePrivate, _global: any) {
     return;
   }
 
+  // o is 'undefined' string
   const supportsWebSocket = typeof WebSocket !== o;
   if (canPatchViaPropertyDescriptor()) {
     const ignoreProperties: IgnoreProperty[] = _global.__Zone_ignore_on_properties;
@@ -306,6 +307,7 @@ export function propertyDescriptorPatch(api: _ZonePrivate, _global: any) {
           XMLHttpRequestEventTarget && XMLHttpRequestEventTarget.prototype,
           XMLHttpRequestEventNames, ignoreProperties);
     }
+    // o is 'undefined' string
     if (typeof IDBIndex !== o) {
       patchFilteredProperties(IDBIndex.prototype, IDBIndexEventNames, ignoreProperties);
       patchFilteredProperties(IDBRequest.prototype, IDBIndexEventNames, ignoreProperties);
@@ -338,6 +340,7 @@ function canPatchViaPropertyDescriptor() {
   const ON_READY_STATE_CHANGE = 'onreadystatechange';
   const XMLHttpRequestPrototype = XMLHttpRequest.prototype;
 
+  // a is Object.getOwnPropertyDescriptor
   const xhrDesc = a(XMLHttpRequestPrototype, ON_READY_STATE_CHANGE);
 
   // add enumerable and configurable here because in opera
@@ -347,6 +350,7 @@ function canPatchViaPropertyDescriptor() {
   // and if XMLHttpRequest.prototype.onreadystatechange is undefined,
   // we should set a real desc instead a fake one
   if (xhrDesc) {
+    // b is Object.defineProperty
     b(XMLHttpRequestPrototype, ON_READY_STATE_CHANGE, {
       enumerable: true,
       configurable: true,
@@ -398,6 +402,7 @@ function patchViaCapturingAllTheEvents() {
       }
       while (elt) {
         if (elt[onproperty] && !elt[onproperty][unboundKey]) {
+          // Zone.current.wrap
           bound = (Zone as any).c.w(elt[onproperty], source);
           bound[unboundKey] = elt[onproperty];
           elt[onproperty] = bound;

Diff for: lib/browser/register-element.ts

@@ -25,6 +25,7 @@ export function registerElementPatch(_global: any) {
         const source = 'Document.registerElement::' + callback;
         const p = opts.prototype;
         if (p.hasOwnProperty(callback)) {
+          // a is Object.getOwnPropertyDescriptor
           const descriptor = a(p, callback);
           if (descriptor && descriptor.value) {
             descriptor.value = (Zone as any).c.w(descriptor.value, source);

Diff for: lib/browser/websocket.ts

@@ -24,13 +24,16 @@ export function apply(api: _ZonePrivate, _global: any) {
     let proxySocketProto: any;
 
     // Safari 7.0 has non-configurable own 'onmessage' and friends properties on the socket instance
+    // a is Object.getOwnPropertyDescriptor
     const onmessageDesc = a(socket, 'onmessage');
     if (onmessageDesc && onmessageDesc.configurable === false) {
+      // e is Object.create
       proxySocket = e(socket);
       // socket have own property descriptor 'onopen', 'onmessage', 'onclose', 'onerror'
       // but proxySocket not, so we will keep socket as prototype and pass it to
       // patchOnProperties method
       proxySocketProto = socket;
+      // g is `addEventListener`, h is `removeEventListener` string
       [g, h, 'send', 'close'].forEach(function(propName) {
         proxySocket[propName] = function() {
           const args = f.call(arguments);

Diff for: lib/common/events.ts

@@ -75,6 +75,7 @@ export function patchEventTarget(
       return;
     }
     const delegate = task.callback;
+    // p is 'object' string
     if (typeof delegate === p && delegate.handleEvent) {
       // create the bind version of handleEvent when invoke
       task.callback = (event: Event) => delegate.handleEvent(event);
@@ -83,6 +84,7 @@ export function patchEventTarget(
     // invoke static task.invoke
     task.invoke(task, target, [event]);
     const options = task.options;
+    // p is 'object' string
     if (options && typeof options === p && options.once) {
       // if options.once is true, after invoke once remove listener here
       // only browser need to do this, nodejs eventEmitter will cal removeListener
@@ -103,6 +105,7 @@ export function patchEventTarget(
     // event.target is needed for Samusung TV and SourceBuffer
     // || global is needed https://github.com/angular/zone.js/issues/190
     const target: any = this || event.target || _global;
+    // l is 'false' string
     const tasks = target[ens[event.type][l]];
     if (tasks) {
       // invoke all tasks which attached to current target with given event.type and capture = false
@@ -135,6 +138,7 @@ export function patchEventTarget(
     // event.target is needed for Samusung TV and SourceBuffer
     // || global is needed https://github.com/angular/zone.js/issues/190
     const target: any = this || event.target || _global;
+    // k is 'true' string
     const tasks = target[ens[event.type][k]];
     if (tasks) {
       // invoke all tasks which attached to current target with given event.type and capture = false
@@ -179,6 +183,7 @@ export function patchEventTarget(
 
     let proto = obj;
     while (proto && !proto.hasOwnProperty(ADD_EVENT_LISTENER)) {
+      // d is Object.getPrototypeOf
       proto = d(proto);
     }
     if (!proto && obj[ADD_EVENT_LISTENER]) {
@@ -230,9 +235,11 @@ export function patchEventTarget(
       // from Zone.prototype.cancelTask, we should remove the task
       // from tasksList of target first
       if (!task.isRemoved) {
+        // ens is event names cache
         const symbolEventNames = ens[task.eventName];
         let symbolEventName;
         if (symbolEventNames) {
+          // k is 'true' string, l is 'false' string
           symbolEventName = symbolEventNames[task.capture ? k : l];
         }
         const existingTasks = symbolEventName && task.target[symbolEventName];
@@ -286,6 +293,7 @@ export function patchEventTarget(
 
     const compareTaskCallbackVsDelegate = function(task: any, delegate: any) {
       const typeOfDelegate = typeof delegate;
+      // n is 'function' string, p is 'object' string
       if ((typeOfDelegate === n && task.callback === delegate) ||
           (typeOfDelegate === p && task.originalDelegate === delegate)) {
         // same callback, same capture, same event name, just return
@@ -313,6 +321,7 @@ export function patchEventTarget(
         // case here to improve addEventListener performance
         // we will create the bind delegate when invoke
         let isHandleEvent = false;
+        // n is 'function' string
         if (typeof delegate !== n) {
           if (!delegate.handleEvent) {
             return nativeListener.apply(this, arguments);
@@ -349,16 +358,20 @@ export function patchEventTarget(
           once = options ? !!options.once : false;
         }
 
+        // Zone.current
         const zone = (Zone as any).c;
         const symbolEventNames = ens[eventName];
         let symbolEventName;
         if (!symbolEventNames) {
           // the code is duplicate, but I just want to get some better performance
+          // l is 'false' string, k is 'true' string
           const falseEventName = eventName + l;
           const trueEventName = eventName + k;
+          // m is '__zone_symbol__' string
           const symbol = m + falseEventName;
           const symbolCapture = m + trueEventName;
           ens[eventName] = {};
+          // l is 'false' string, k is 'true' string
           ens[eventName][l] = symbol;
           ens[eventName][k] = symbolCapture;
           symbolEventName = capture ? symbolCapture : symbol;
@@ -411,6 +424,7 @@ export function patchEventTarget(
           (data as any).taskData = taskData;
         }
 
+        // Zone.scehduleEventTask
         const task: any =
             (zone as any).se(source, delegate, data, customScheduleFn, customCancelFn);
 
@@ -553,6 +567,7 @@ export function patchEventTarget(
       } else {
         const symbolEventNames = ens[eventName];
         if (symbolEventNames) {
+          // l is 'false' string, k is 'true' string
           const symbolEventName = symbolEventNames[l];
           const symbolCaptureEventName = symbolEventNames[k];