Fixes GitHub action configurations and make tests works

Author: pftg

.github/workflows/test.yml

@@ -10,7 +10,8 @@ env:
   SPEC_OPTS: '--backtrace'
 
 jobs:
-  name: Lint
+  lint:
+    name: Lint
     runs-on: ubuntu-latest
 
     steps:
@@ -24,15 +25,15 @@ jobs:
           bundler-cache: true
 
       - name: Run Standard Ruby linter
-        run: bin/standardrb --no-fix --fail-fast
+        run: bundle exec standardrb --no-fix --fail-fast
         continue-on-error: true
 
   test:
     name: Functional Testing
-    runs-on: ubuntu-20.04 # In order to install libvips 8.9+ version
 
     strategy:
       matrix:
+        os-version: [ 'ubuntu-20.04' ]
         ruby-version:
           - 2.1
           - 2.2
@@ -42,6 +43,9 @@ jobs:
           - 2.6
           - 2.7
           - jruby
+      fail-fast: true
+
+    runs-on: ${{ matrix.os-version }}
 
     steps:
       - name: Checkout code
@@ -62,28 +66,8 @@ jobs:
         env:
           DEBIAN_FRONTEND: noninteractive
         run:
-          sudo apt install --fix-missing -qq --no-install-recommends -o Acquire::Retries=3
+          sudo apt install --fix-missing -qq -o Acquire::Retries=3
             libvips libvips-dev libvips-tools
-            gettext
-            libcfitsio-dev
-            libexpat1-dev
-            libfftw3-dev
-            libgif-dev
-            libglib2.0-dev
-            libgsf-1-dev
-            libjpeg-turbo8-dev
-            liblcms2-dev
-            libmagickwand-dev
-            libmatio-dev
-            libopenexr-dev
-            libopenslide-dev
-            liborc-0.4-dev
-            libpango1.0-dev
-            libpoppler-glib-dev
-            libtiff5-dev
-            libwebp-dev
-            librsvg2-dev
-            libmagick++-dev
 
       - name: Run Tests
         run: bundle exec rake spec

.yardopts

@@ -1,2 +1 @@
---markup-provider=redcarpet
 --markup=markdown

Gemfile

@@ -4,5 +4,3 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'github-markup'
-gem 'redcarpet', platforms: :ruby
-gem 'standard', platforms: :ruby

ruby-vips.gemspec

@@ -47,7 +47,7 @@ and it can process large images without loading the whole image in memory.
 
   # RuboCop requires Ruby >= 2.2
   if Gem.ruby_version >= Gem::Version.new("2.2")
-    spec.add_development_dependency "rubocop", ["~> 0.64"]
+    spec.add_development_dependency "standard"
   end
 
 end

spec/connection_spec.rb

@@ -1,170 +1,163 @@
 require 'spec_helper.rb'
 
-if Vips::at_least_libvips?(8, 9)
-  RSpec.describe Vips::Source do
-    it 'can create a source from a descriptor' do
-      source = Vips::Source.new_from_descriptor(0)
+RSpec.describe Vips::Source, version: [8, 9] do
+  it 'can create a source from a descriptor' do
+    source = Vips::Source.new_from_descriptor(0)
 
-      expect(source)
-    end
+    expect(source)
+  end
 
-    it 'can create a source from a filename' do
-      source = Vips::Source.new_from_file simg('wagon.jpg')
+  it 'can create a source from a filename' do
+    source = Vips::Source.new_from_file simg('wagon.jpg')
 
-      expect(source)
-    end
+    expect(source)
+  end
 
-    it 'can\'t create a source from a bad filename' do
-      expect { 
-        Vips::Source.new_from_file simg('banana.jpg') 
-      }.to raise_exception(Vips::Error)
-    end
+  it 'can\'t create a source from a bad filename' do
+    expect {
+      Vips::Source.new_from_file simg('banana.jpg')
+    }.to raise_exception(Vips::Error)
+  end
 
-    it 'can create a source from an area of memory' do
-      str = File.open(simg('wagon.jpg'), 'rb').read
-      source = Vips::Source.new_from_memory str
+  it 'can create a source from an area of memory' do
+    str = File.open(simg('wagon.jpg'), 'rb').read
+    source = Vips::Source.new_from_memory str
 
-      expect(source)
-    end
+    expect(source)
+  end
 
-    it 'sources have filenames and nicks' do
-      source = Vips::Source.new_from_file simg('wagon.jpg')
+  it 'sources have filenames and nicks' do
+    source = Vips::Source.new_from_file simg('wagon.jpg')
 
-      expect(source.filename).to eq(simg('wagon.jpg'))
-      expect(source.nick)
-    end
+    expect(source.filename).to eq(simg('wagon.jpg'))
+    expect(source.nick)
+  end
 
-    it 'can load an image from filename source' do
-      source = Vips::Source.new_from_file simg('wagon.jpg')
-      image = Vips::Image.new_from_source source, ''
+  it 'can load an image from filename source' do
+    source = Vips::Source.new_from_file simg('wagon.jpg')
+    image = Vips::Image.new_from_source source, ''
 
-      expect(image)
-      expect(image.width).to eq(685)
-      expect(image.height).to eq(478)
-      expect(image.bands).to eq(3)
-      expect(image.avg).to be_within(0.001).of(109.789)
+    expect(image)
+    expect(image.width).to eq(685)
+    expect(image.height).to eq(478)
+    expect(image.bands).to eq(3)
+    expect(image.avg).to be_within(0.001).of(109.789)
 
-    end
   end
 end
 
-if Vips::at_least_libvips?(8, 9)
-  RSpec.describe Vips::Target do
-    it 'can create a target to a filename' do
-      target = Vips::Target.new_to_file timg('x.jpg')
-
-      expect(target)
-    end
-
-    it 'can create a target to a descriptor' do
-      target = Vips::Target.new_to_descriptor 1
-
-      expect(target)
-    end
-
-    it 'can create a target to a memory area' do
-      target = Vips::Target.new_to_memory
-
-      expect(target)
-    end
-
-    it 'can\'t create a target to a bad filename' do
-      expect { 
-        Vips::Target.new_to_file '/banana/monkey'
-      }.to raise_exception(Vips::Error)
-    end
-
-    it 'can save an image to a filename target' do
-      source = Vips::Source.new_from_file simg('wagon.jpg')
-      image = Vips::Image.new_from_source source, ''
-      filename = timg('x4.png')
-      target = Vips::Target.new_to_file filename
-      image.write_to_target target, '.png'
-
-      image = Vips::Image.new_from_file filename
-      expect(image)
-      expect(image.width).to eq(685)
-      expect(image.height).to eq(478)
-      expect(image.bands).to eq(3)
-      expect(image.avg).to be_within(0.001).of(109.789)
-    end
-
-    it 'can save an image to a memory target' do
-      source = Vips::Source.new_from_file simg('wagon.jpg')
-      image = Vips::Image.new_from_source source, ''
-      target = Vips::Target.new_to_memory
-      image.write_to_target target, '.png'
-      memory = target.get('blob')
-
-      image = Vips::Image.new_from_buffer memory, ''
-      expect(image)
-      expect(image.width).to eq(685)
-      expect(image.height).to eq(478)
-      expect(image.bands).to eq(3)
-      expect(image.avg).to be_within(0.001).of(109.789)
-    end
+RSpec.describe Vips::Target, version: [8, 9] do
+  it 'can create a target to a filename' do
+    target = Vips::Target.new_to_file timg('x.jpg')
+
+    expect(target)
+  end
+
+  it 'can create a target to a descriptor' do
+    target = Vips::Target.new_to_descriptor 1
+
+    expect(target)
+  end
+
+  it 'can create a target to a memory area' do
+    target = Vips::Target.new_to_memory
 
+    expect(target)
   end
+
+  it 'can\'t create a target to a bad filename' do
+    expect {
+      Vips::Target.new_to_file '/banana/monkey'
+    }.to raise_exception(Vips::Error)
+  end
+
+  it 'can save an image to a filename target' do
+    source = Vips::Source.new_from_file simg('wagon.jpg')
+    image = Vips::Image.new_from_source source, ''
+    filename = timg('x4.png')
+    target = Vips::Target.new_to_file filename
+    image.write_to_target target, '.png'
+
+    image = Vips::Image.new_from_file filename
+    expect(image)
+    expect(image.width).to eq(685)
+    expect(image.height).to eq(478)
+    expect(image.bands).to eq(3)
+    expect(image.avg).to be_within(0.001).of(109.789)
+  end
+
+  it 'can save an image to a memory target' do
+    source = Vips::Source.new_from_file simg('wagon.jpg')
+    image = Vips::Image.new_from_source source, ''
+    target = Vips::Target.new_to_memory
+    image.write_to_target target, '.png'
+    memory = target.get('blob')
+
+    image = Vips::Image.new_from_buffer memory, ''
+    expect(image)
+    expect(image.width).to eq(685)
+    expect(image.height).to eq(478)
+    expect(image.bands).to eq(3)
+    expect(image.avg).to be_within(0.001).of(109.789)
+  end
+
 end
 
-if Vips::at_least_libvips?(8, 9)
-  RSpec.describe Vips::SourceCustom do
-    it 'can create a custom source' do
-      source = Vips::SourceCustom.new
-
-      expect(source)
-    end
-
-    it 'can load a custom source' do
-      file = File.open simg('wagon.jpg'), "rb"
-      source = Vips::SourceCustom.new
-      source.on_read { |length| file.read length }
-      source.on_seek { |offset, whence| file.seek(offset, whence) }
-      image = Vips::Image.new_from_source source, ""
-
-      expect(image)
-      expect(image.width).to eq(685)
-      expect(image.height).to eq(478)
-      expect(image.bands).to eq(3)
-      expect(image.avg).to be_within(0.001).of(109.789)
-    end
-
-    it 'on_seek is optional' do
-      file = File.open simg('wagon.jpg'), "rb"
-      source = Vips::SourceCustom.new
-      source.on_read { |length| file.read length }
-      image = Vips::Image.new_from_source source, ""
-
-      expect(image)
-      expect(image.width).to eq(685)
-      expect(image.height).to eq(478)
-      expect(image.bands).to eq(3)
-      expect(image.avg).to be_within(0.001).of(109.789)
-    end
-
-    it 'can create a user output stream' do
-      target = Vips::TargetCustom.new
-
-      expect(target)
-    end
-
-    it 'can write an image to a user output stream' do
-      filename = timg('x5.png')
-      file = File.open filename, "wb"
-      target = Vips::TargetCustom.new
-      target.on_write { |chunk| file.write(chunk) }
-      target.on_finish { file.close }
-      image = Vips::Image.new_from_file simg('wagon.jpg')
-      image.write_to_target target, ".png"
-
-      image = Vips::Image.new_from_file filename
-      expect(image)
-      expect(image.width).to eq(685)
-      expect(image.height).to eq(478)
-      expect(image.bands).to eq(3)
-      expect(image.avg).to be_within(0.001).of(109.789)
-    end
+RSpec.describe Vips::SourceCustom, version: [8, 9] do
+  it 'can create a custom source' do
+    source = Vips::SourceCustom.new
+
+    expect(source)
+  end
+
+  it 'can load a custom source' do
+    file = File.open simg('wagon.jpg'), "rb"
+    source = Vips::SourceCustom.new
+    source.on_read { |length| file.read length }
+    source.on_seek { |offset, whence| file.seek(offset, whence) }
+    image = Vips::Image.new_from_source source, ""
+
+    expect(image)
+    expect(image.width).to eq(685)
+    expect(image.height).to eq(478)
+    expect(image.bands).to eq(3)
+    expect(image.avg).to be_within(0.001).of(109.789)
+  end
+
+  it 'on_seek is optional' do
+    file = File.open simg('wagon.jpg'), "rb"
+    source = Vips::SourceCustom.new
+    source.on_read { |length| file.read length }
+    image = Vips::Image.new_from_source source, ""
+
+    expect(image)
+    expect(image.width).to eq(685)
+    expect(image.height).to eq(478)
+    expect(image.bands).to eq(3)
+    expect(image.avg).to be_within(0.001).of(109.789)
+  end
+
+  it 'can create a user output stream' do
+    target = Vips::TargetCustom.new
+
+    expect(target)
+  end
 
+  it 'can write an image to a user output stream' do
+    filename = timg('x5.png')
+    file = File.open filename, "wb"
+    target = Vips::TargetCustom.new
+    target.on_write { |chunk| file.write(chunk) }
+    target.on_finish { file.close }
+    image = Vips::Image.new_from_file simg('wagon.jpg')
+    image.write_to_target target, ".png"
+
+    image = Vips::Image.new_from_file filename
+    expect(image)
+    expect(image.width).to eq(685)
+    expect(image.height).to eq(478)
+    expect(image.bands).to eq(3)
+    expect(image.avg).to be_within(0.001).of(109.789)
   end
 
 end