Housekeeping

* Update deps
* Update tests
* removed .npmignore

Author: ankurk91

.editorconfig

@@ -34,5 +34,5 @@ spaces_around_operators = true
 indent_brace_style = 1TBS
 spaces_around_brackets = both
 
-[*.{scss,css,js,html,json,vue,yml,babelrc,eslintrc}]
+[*.{scss,css,js,ts,html,json,vue,yml,babelrc,eslintrc}]
 indent_size = 2

.github/CONTRIBUTING.md

@@ -7,20 +7,17 @@
 
 
 ### Pull requests guidelines
-* Checkout a topic branch from the relevant branch, and merge back against that branch.
+* Always create a separate branch from `master` branch for your commits.
+* One concern one PR.
 * It's OK to have multiple small commits as you work on the PR - we will let GitHub automatically squash it before merging.
-* Work in ``src`` folder never touch or commit in ``dist`` folder
 
 
 ### Development setup
-* You will need [node-js](http://nodejs.org/) >=6.10 || >=9.0 and [yarn](https://yarnpkg.com/en/docs/install) v1.x
-* After cloning the repo, run:
-```
-yarn install
-```
+* Install [node-js](http://nodejs.org/) >=6.10 || >=9.0 and [yarn](https://yarnpkg.com/en/docs/install) v1.x
+* Clone the repo
+* Create a separate branch `git checkout -b your-branch-name`
+* Install dependencies : `yarn install`
 * Make changes in ``src`` folder
 * Write/update test case for the feature/fix you made 
-* You can check if everything is working fine by running tests
-```
-yarn test
-```
+* You can check if everything is working fine by running tests `yarn test`
+

.gitignore

@@ -10,7 +10,6 @@
 *.sublime-*
 .brackets.json
 .vscode
-_notes
 
 # logs and cache
 /logs/
@@ -52,9 +51,6 @@ node_modules/
 # bower packages
 bower_components/
 
-# svn folders
-.svn/
-
 # Composer, exclude on root vendor folder
 /vendor/
 composer.phar

.npmignore

@@ -10,7 +10,7 @@ git:
   depth: 10
   submodules: false
 
-# Install custom version
+# Install specific version
 before_install:
   - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.3.2
   - export PATH="$HOME/.yarn/bin:$PATH"
@@ -25,7 +25,7 @@ script:
 after_success:
   - bash <(curl -s https://codecov.io/bash) -e TRAVIS_NODE_VERSION
 
-# Tell Travis CI to monitor only these branches
+# Monitor only these branches
 branches:
   only:
   - master

.travis.yml

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2017 Ankur Kumar
+Copyright (c) Ankur Kumar
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

LICENSE.txt

@@ -21,6 +21,7 @@ describe('Flatpickr events', () => {
   afterEach(() => {
     wrapper.destroy();
     wrapper = null;
+    jest.resetAllMocks();
   });
 
   test('emits change event on value change', () => {
@@ -29,7 +30,6 @@ describe('Flatpickr events', () => {
     wrapper.setProps({value: '2017-10-04'});
 
     expect(stub).toHaveBeenCalled();
-    stub.mockClear();
   });
 
   test('emits open event on focus', () => {
@@ -38,14 +38,12 @@ describe('Flatpickr events', () => {
     wrapper.trigger('focus');
 
     expect(stub).toHaveBeenCalled();
-    stub.mockClear();
   });
 
   test('calls original onChange method on value change', () => {
     wrapper.setProps({value: '2017-10-04'});
 
     expect(onChangeStub).toHaveBeenCalled();
-    onChangeStub.mockReset();
   });
 
 

__test__/events.spec.js

@@ -5,12 +5,12 @@ describe('Flatpickr global component', () => {
 
   // Make a copy of local vue
   let localVue = createLocalVue();
-  // Define a global component
+  // Define the global component
   localVue.use(Component, 'date-picker');
 
   test('works as plugin', () => {
 
-    let app = localVue.component('app', {
+    let app = {
       template: `<div id="app">
                   <date-picker class="form-control" name="date" v-model="date"></date-picker>
                  </div>`,
@@ -19,7 +19,7 @@ describe('Flatpickr global component', () => {
           date: '2017-10-04'
         }
       }
-    });
+    };
 
     let wrapper = mount(app, {
       localVue
@@ -31,7 +31,7 @@ describe('Flatpickr global component', () => {
     expect(input.is('input')).toBe(true);
     expect(input.vm.$el.value).toBe('2017-10-04');
     expect(input.classes()).toContain('form-control');
-    expect(input.vm.$el.getAttribute('name')).toBe('date');
+    expect(input.attributes().name).toBe('date');
 
     wrapper.destroy();
   });

__test__/plugin.spec.js

@@ -26,7 +26,6 @@ describe('Flatpickr props', () => {
 
   test('accepts config via prop', () => {
     expect(wrapper.props().config).toEqual(props.config);
-    // fp contains the flatpickr instance
     expect(wrapper.vm.fp.config).toHaveProperty('dateFormat', props.config.dateFormat);
   });
 

__test__/props.spec.js

@@ -20,7 +20,7 @@ describe('Flatpickr watchers', () => {
     wrapper = null;
   });
 
-  test('updates input value in DOM on value change', () => {
+  test('updates input value in DOM on value changed from parent component', () => {
     wrapper.setProps({value: '2019-10-04'});
     expect(wrapper.vm.$el.value).toEqual('2019-10-04');
   });

__test__/watchers.spec.js

@@ -67,7 +67,7 @@
                           ref="datePickerWrap"
               >
               </flat-pickr>
-              <div class="input-group-btn">
+              <div class="input-group-append">
                 <button class="btn btn-success" type="button" title="Toggle" data-toggle>
                   Toggle
                 </button>
@@ -90,7 +90,7 @@
             <div class="input-group">
               <flat-pickr :config="configs.timePicker" class="form-control" v-model="form.time"
                           placeholder="Time"></flat-pickr>
-              <div class="input-group-btn">
+              <div class="input-group-append">
                 <button class="btn btn-secondary" type="button" title="Toggle" data-toggle>
                   Clock
                 </button>

examples/App.vue

@@ -4,6 +4,10 @@
   "description": "Vue.js component for Flatpickr date-time picker",
   "main": "dist/vue-flatpickr.js",
   "unpkg": "dist/vue-flatpickr.min.js",
+  "files": [
+    "src",
+    "dist"
+  ],
   "repository": {
     "type": "git",
     "url": "git+https://github.com/ankurk91/vue-flatpickr-component.git"
@@ -12,7 +16,8 @@
     "vue",
     "flatpickr",
     "vue-flatpickr",
-    "datepicker"
+    "datepicker",
+    "timepicker"
   ],
   "author": "ankurk91",
   "license": "MIT",
@@ -29,30 +34,30 @@
     "prepublishOnly": "npm run test && npm run build"
   },
   "dependencies": {
-    "flatpickr": "^4.1.4"
+    "flatpickr": "^4.2.3"
   },
   "devDependencies": {
     "babel-core": "^6.25.0",
     "babel-loader": "^7.1.0",
     "babel-preset-env": "^1.6.1",
-    "bootstrap": "^4.0.0-beta.2",
+    "bootstrap": "^4.0.0-beta.3",
     "clean-webpack-plugin": "^0.1.16",
-    "css-loader": "^0.28.4",
+    "css-loader": "^0.28.8",
     "file-loader": "^1.1.6",
     "html-webpack-plugin": "^2.30.1",
-    "jest": "^22.0.3",
+    "jest": "^22.0.4",
     "jquery": "^3.2.1",
     "popper.js": "^1.12.9",
     "style-loader": "^0.19.1",
     "unminified-webpack-plugin": "^1.4.2",
-    "vee-validate": "^2.0.0-rc.27",
+    "vee-validate": "^2.0.0",
     "vue": "^2.5.13",
     "vue-jest": "^1.4.0",
-    "vue-loader": "^13.6.0",
+    "vue-loader": "^13.6.2",
     "vue-template-compiler": "^2.5.13",
-    "vue-test-utils": "^1.0.0-beta.8",
+    "vue-test-utils": "^1.0.0-beta.9",
     "webpack": "^3.10.0",
-    "webpack-dev-server": "^2.9.7"
+    "webpack-dev-server": "^2.10.0"
   },
   "peerDependencies": {
     "vue": "^2.0.0"

package.json

@@ -10,7 +10,7 @@ module.exports = {
     modules: [
       path.resolve(__dirname, 'src'),
       path.resolve(__dirname, 'examples'),
-      'node_modules'
+      path.resolve(__dirname, 'node_modules'),
     ],
     alias: {
       'vue$': 'vue/dist/vue.esm.js'
@@ -64,8 +64,6 @@ module.exports = {
         minifyJS: false,
         minifyCSS: false,
         minifyURLs: false
-        // More options here
-        // https://github.com/kangax/html-minifier#options-quick-reference
       }
     }),
     new webpack.ProvidePlugin({