Do not use worker threads to launching binaries (microsoft#23030)

Author: Kartik Raj

src/client/pythonEnvironments/base/locators/lowLevel/condaLocator.ts

@@ -6,8 +6,6 @@ import { BasicEnvInfo, IPythonEnvsIterator } from '../../locator';
 import { Conda, getCondaEnvironmentsTxt } from '../../../common/environmentManagers/conda';
 import { traceError, traceVerbose } from '../../../../logging';
 import { FSWatchingLocator } from './fsWatchingLocator';
-import { DiscoveryUsingWorkers } from '../../../../common/experiments/groups';
-import { inExperiment } from '../../../common/externalDependencies';
 
 export class CondaEnvironmentLocator extends FSWatchingLocator {
     public readonly providerId: string = 'conda-envs';
@@ -21,10 +19,7 @@ export class CondaEnvironmentLocator extends FSWatchingLocator {
     }
 
     // eslint-disable-next-line class-methods-use-this
-    public async *doIterEnvs(
-        _: unknown,
-        useWorkerThreads = inExperiment(DiscoveryUsingWorkers.experiment),
-    ): IPythonEnvsIterator<BasicEnvInfo> {
+    public async *doIterEnvs(_: unknown, useWorkerThreads = false): IPythonEnvsIterator<BasicEnvInfo> {
         const conda = await Conda.getConda(undefined, useWorkerThreads);
         if (conda === undefined) {
             traceVerbose(`Couldn't locate the conda binary.`);

src/client/pythonEnvironments/base/locators/lowLevel/windowsRegistryLocator.ts

@@ -8,8 +8,6 @@ import { BasicEnvInfo, IPythonEnvsIterator, Locator, PythonLocatorQuery, IEmitte
 import { getRegistryInterpreters } from '../../../common/windowsUtils';
 import { traceError, traceVerbose } from '../../../../logging';
 import { isMicrosoftStoreDir } from '../../../common/environmentManagers/microsoftStoreEnv';
-import { inExperiment } from '../../../common/externalDependencies';
-import { DiscoveryUsingWorkers } from '../../../../common/experiments/groups';
 import { PythonEnvsChangedEvent } from '../../watcher';
 
 export const WINDOWS_REG_PROVIDER_ID = 'windows-registry';
@@ -18,10 +16,7 @@ export class WindowsRegistryLocator extends Locator<BasicEnvInfo> {
     public readonly providerId: string = WINDOWS_REG_PROVIDER_ID;
 
     // eslint-disable-next-line class-methods-use-this
-    public iterEnvs(
-        query?: PythonLocatorQuery,
-        useWorkerThreads = inExperiment(DiscoveryUsingWorkers.experiment),
-    ): IPythonEnvsIterator<BasicEnvInfo> {
+    public iterEnvs(query?: PythonLocatorQuery, useWorkerThreads = false): IPythonEnvsIterator<BasicEnvInfo> {
         if (useWorkerThreads) {
             /**
              * Windows registry is slow and often not necessary, so notify completion immediately, but use watcher

src/client/pythonEnvironments/common/environmentManagers/conda.ts

@@ -10,7 +10,6 @@ import {
     readFile,
     onDidChangePythonSetting,
     exec,
-    inExperiment,
 } from '../externalDependencies';
 
 import { PythonVersion, UNKNOWN_PYTHON_VERSION } from '../../base/info';
@@ -25,7 +24,6 @@ import { OUTPUT_MARKER_SCRIPT } from '../../../common/process/internal/scripts';
 import { splitLines } from '../../../common/stringUtils';
 import { SpawnOptions } from '../../../common/process/types';
 import { sleep } from '../../../common/utils/async';
-import { DiscoveryUsingWorkers } from '../../../common/experiments/groups';
 
 export const AnacondaCompanyName = 'Anaconda, Inc.';
 export const CONDAPATH_SETTING_KEY = 'condaPath';
@@ -274,11 +272,7 @@ export class Conda {
         private readonly useWorkerThreads?: boolean,
     ) {
         if (this.useWorkerThreads === undefined) {
-            try {
-                this.useWorkerThreads = inExperiment(DiscoveryUsingWorkers.experiment);
-            } catch {
-                this.useWorkerThreads = false; // Temporarily support for legacy tests
-            }
+            this.useWorkerThreads = false;
         }
         this.shellCommand = shellCommand ?? command;
         onDidChangePythonSetting(CONDAPATH_SETTING_KEY, () => {
@@ -302,11 +296,7 @@ export class Conda {
     private static async locate(shellPath?: string, useWorkerThread?: boolean): Promise<Conda | undefined> {
         let useWorkerThreads: boolean;
         if (useWorkerThread === undefined) {
-            try {
-                useWorkerThreads = inExperiment(DiscoveryUsingWorkers.experiment);
-            } catch {
-                useWorkerThreads = false; // Temporarily support for legacy tests
-            }
+            useWorkerThreads = false;
         }
         traceVerbose(`Searching for conda.`);
         const home = getUserHomeDir();

src/client/pythonEnvironments/common/externalDependencies.ts

@@ -11,7 +11,6 @@ import { chain, iterable } from '../../common/utils/async';
 import { getOSType, OSType } from '../../common/utils/platform';
 import { IServiceContainer } from '../../ioc/types';
 import { traceError, traceVerbose } from '../../logging';
-import { DiscoveryUsingWorkers } from '../../common/experiments/groups';
 
 let internalServiceContainer: IServiceContainer;
 export function initializeExternalDependencies(serviceContainer: IServiceContainer): void {
@@ -21,7 +20,7 @@ export function initializeExternalDependencies(serviceContainer: IServiceContain
 // processes
 
 export async function shellExecute(command: string, options: ShellOptions = {}): Promise<ExecutionResult<string>> {
-    const useWorker = inExperiment(DiscoveryUsingWorkers.experiment);
+    const useWorker = false;
     const service = await internalServiceContainer.get<IProcessServiceFactory>(IProcessServiceFactory).create();
     options = { ...options, useWorker };
     return service.shellExec(command, options);
@@ -31,7 +30,7 @@ export async function exec(
     file: string,
     args: string[],
     options: SpawnOptions = {},
-    useWorker = inExperiment(DiscoveryUsingWorkers.experiment),
+    useWorker = false,
 ): Promise<ExecutionResult<string>> {
     const service = await internalServiceContainer.get<IProcessServiceFactory>(IProcessServiceFactory).create();
     options = { ...options, useWorker };