fix: eslint nits

Author: rusackas

packages/superset-ui-legacy-plugin-chart-treemap/src/transformProps.js

@@ -24,7 +24,7 @@ export default function transformProps(chartProps) {
 
   if (!numberFormat && chartProps.datasource && chartProps.datasource.metrics) {
     chartProps.datasource.metrics.forEach(metric => {
-      if (metric.metric_name == chartProps.formData.metrics[0] && metric.d3format) {
+      if (metric.metric_name === chartProps.formData.metrics[0] && metric.d3format) {
         numberFormat = metric.d3format;
       }
     });

packages/superset-ui-legacy-preset-chart-big-number/src/BigNumber/transformProps.js

@@ -86,9 +86,9 @@ export default function transformProps(chartProps) {
   }
   let metricFormat = yAxisFormat;
   if (!yAxisFormat && chartProps.datasource && chartProps.datasource.metrics) {
-    chartProps.datasource.metrics.forEach(metric => {
-      if (metric.metric_name == metric && metric.d3format) {
-        metricFormat = metric.d3format;
+    chartProps.datasource.metrics.forEach(metricEntry => {
+      if (metricEntry.metric_name === metric && metricEntry.d3format) {
+        metricFormat = metricEntry.d3format;
       }
     });
   }

packages/superset-ui-legacy-preset-chart-nvd3/src/transformProps.js

@@ -85,12 +85,13 @@ export default function transformProps(chartProps) {
         foundFormatter = metric.d3format;
       }
     });
+
     return foundFormatter;
   };
 
-  if (chartProps.formData.vizType == 'pie') {
+  if (chartProps.formData.vizType === 'pie') {
     numberFormat = grabD3Format(chartProps.formData.metric) || numberFormat;
-  } else if (chartProps.formData.vizType == 'dual_line') {
+  } else if (chartProps.formData.vizType === 'dual_line') {
     yAxisFormat = grabD3Format(chartProps.formData.metric) || yAxisFormat;
     yAxis2Format = grabD3Format(chartProps.formData.metric2) || yAxis2Format;
   } else if (['line', 'dist_bar', 'bar', 'area'].indexOf(chartProps.formData.vizType) > -1) {