Skip to content

Parameter error in VerifyCode Test Case #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sosyz opened this issue Jul 30, 2024 · 0 comments · Fixed by #1060
Closed

Parameter error in VerifyCode Test Case #1059

sosyz opened this issue Jul 30, 2024 · 0 comments · Fixed by #1060
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@sosyz
Copy link
Member

sosyz commented Jul 30, 2024

Describe the bug

The test code in the line is missing a parameter.

The function definition is:

SetCode(ctx context.Context, userID, code, content string, duration time.Duration) error

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to internal/repo/repo_test/email_repo_test.go
  2. Check line 34.

Expected behavior

Add a userID parameter and update the content var accordingly. The content variable needs to be updated because "test" cannot be parsed in the new version.

image

Additional Information

I can create a pull request to fix this issue if needed.

@sosyz sosyz added the bug Something isn't working label Jul 30, 2024
@LinkinStars LinkinStars added the good first issue Good for newcomers label Jul 31, 2024
@sosyz sosyz closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants