Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some translations do not work #309

Closed
BingYanchi opened this issue Apr 8, 2023 · 19 comments
Closed

Some translations do not work #309

BingYanchi opened this issue Apr 8, 2023 · 19 comments
Assignees
Labels
bug Something isn't working

Comments

@BingYanchi
Copy link

image
image
image

Some translations didn't work, they were focused on the question's action options.

@BingYanchi BingYanchi added the bug Something isn't working label Apr 8, 2023
@LinkinStars LinkinStars self-assigned this Apr 9, 2023
@BingYanchi
Copy link
Author

BingYanchi commented Apr 10, 2023

I found that the localization file contains mail related content, but it didn't take effect. It seems that it saves the format directly into the mysql database when setting up SMTP, and it is only in English. Localized text is not selected according to the language of the site, nor according to the language of the user being sent.

@BingYanchi
Copy link
Author

BingYanchi commented Apr 10, 2023

image
The type in timeline does not seem to use the content in backend.timeline correctly, but selects the content in backend.question_detail.

@LinkinStars
Copy link
Member

I found that the localization file contains mail related content, but it didn't take effect. It seems that it saves the format directly into the database when setting up SMTP, and it is only in English. Localized text is not selected according to the language of the site, nor according to the language of the user being sent.

Since it was considered that the email template might be changed frequently by users, we did not consider internationalizing it, and we could leave it to users to modify it later. However, we will also consider translating the default email templates. Thank you for your feedback.

@LinkinStars
Copy link
Member

LinkinStars commented Apr 10, 2023

image The type in timeline does not seem to use the content in backend.timeline correctly, but selects the content in backend.question_detail.

@BingYanchi Can you describe the problem in a little more detail? We don't quite understand what you mean by backend.timeline and backend.question_detail.

@shuashuai
Copy link
Member

image The type in timeline does not seem to use the content in backend.timeline correctly, but selects the content in backend.question_detail.

I don't understand exactly what you mean by the problem you describe. Our history feature is only for questions, answers, tags, and actions that generate versions to add records, so there is no problem with types here.

@shuashuai shuashuai self-assigned this Apr 10, 2023
@BingYanchi
Copy link
Author

BingYanchi commented Apr 10, 2023

image The type in timeline does not seem to use the content in backend.timeline correctly, but selects the content in backend.question_detail.

I don't understand exactly what you mean by the problem you describe. Our history feature is only for questions, answers, tags, and actions that generate versions to add records, so there is no problem with types here.

I tried to change the backend.timeline in i18n. In theory, he should modify the content in the "类型" of this page. Because the context of "提交于" should not appear in the form.

In the Chinese context. "提交于" should be connected to time. But here is a table. There is no direct connection to time. So I tried to change it to "提交". But it failed. Maybe it used backend.question_detail

I tried to directly modify the local i18n file. And restart the site. But it still didn't take effect.

@BingYanchi
Copy link
Author

image The type in timeline does not seem to use the content in backend.timeline correctly, but selects the content in backend.question_detail.

@BingYanchi Can you describe the problem in a little more detail? We don't quite understand what you mean by backend.timeline and backend.question_detail.

Maybe I didn't express it clearly enough. I was referring to the yaml path in i18n.

@shuashuai
Copy link
Member

shuashuai commented Apr 10, 2023

image The type in timeline does not seem to use the content in backend.timeline correctly, but selects the content in backend.question_detail.

I don't understand exactly what you mean by the problem you describe. Our history feature is only for questions, answers, tags, and actions that generate versions to add records, so there is no problem with types here.

I tried to change the backend.timeline in i18n. In theory, he should modify the content in the "类型" of this page. Because the context of "提交于" should not appear in the form.

In the Chinese context. "提交于" should be connected to time. But here is a table. There is no direct connection to time. So I tried to change it to "提交". But it failed. Maybe it used backend.question_detail

I tried to directly modify the local i18n file. And restart the site. But it still didn't take effect.

You should change the content in ui.timeline. The backend is the translation content applied to the backend, and the content below the ui is the translation content applied to the frontend.Our language file is based on the en_US.yaml file, you can see

image

@BingYanchi
Copy link
Author

image The type in timeline does not seem to use the content in backend.timeline correctly, but selects the content in backend.question_detail.

I don't understand exactly what you mean by the problem you describe. Our history feature is only for questions, answers, tags, and actions that generate versions to add records, so there is no problem with types here.

I tried to change the backend.timeline in i18n. In theory, he should modify the content in the "类型" of this page. Because the context of "提交于" should not appear in the form.

In the Chinese context. "提交于" should be connected to time. But here is a table. There is no direct connection to time. So I tried to change it to "提交". But it failed. Maybe it used backend.question_detail

I tried to directly modify the local i18n file. And restart the site. But it still didn't take effect.

You should change the content in ui.timeline. The backend is the translation content applied to the backend, and the content below the ui is the translation content applied to the frontend.Our language file is based on the en_US.yaml file, you can see

image

Sorry. My description is wrong. What I modified is ui.timeline. But it still doesn’t take effect.

@shuashuai
Copy link
Member

For the development environment, the edits will be logged to take effect after they are done, for the production environment after the edits are done, you need to repackage and deploy the code for it to take effect.

@BingYanchi
Copy link
Author

BingYanchi commented Apr 12, 2023

In 1.0.8, the button below the article may be wrong. (Not sure if the corresponding update was not included in the package.)
image
The other two that were not in effect remain.

image
Besides that, I found that Best answer has no localized statement.

@LinkinStars
Copy link
Member

image

We just did not find this problem after using the Chinese for test. You can check if it is caused by browser cache. Version is (answerdev/answer:1.0.8)

@BingYanchi
Copy link
Author

image

We just did not find this problem after using the Chinese for test. You can check if it is caused by browser cache. Version is (answerdev/answer:1.0.8)

I've tried clearing my browser cache, even on a computer that never visits the site, same thing.

There should be other reasons.

@LinkinStars
Copy link
Member

FYI:

  1. Follow the steps in the documentation to upgrade correctly https://answer.dev/docs/upgrade
  2. Make sure the data/i18n/en_US.yaml language file is the same as the latest language file on github
  3. make sure that the en_US.yaml file contains the key backend.action.report etc.
    Also, may I ask, which way are you using to deploy, docker or binary?

@BingYanchi
Copy link
Author

FYI:

  1. Follow the steps in the documentation to upgrade correctly https://answer.dev/docs/upgrade
  2. Make sure the data/i18n/en_US.yaml language file is the same as the latest language file on github
  3. make sure that the en_US.yaml file contains the key backend.action.report etc.
    Also, may I ask, which way are you using to deploy, docker or binary?

The problem is solved, I am using binary, and it is normal after I manually update the i18n file.

@BingYanchi
Copy link
Author

In 1.0.9, the reason selection in the close and report popups still doesn't take effect. Type filtering in report management is also not localized properly.
image

@LinkinStars
Copy link
Member

In 1.0.9, the reason selection in the close and report popups still doesn't take effect. Type filtering in report management is also not localized properly. image

@shuashuai

@BingYanchi
Copy link
Author

In 1.1.0-beta.2, the reason selection in the close and report popups still doesn't take effect.

@BingYanchi
Copy link
Author

Done in v1.1.0, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants