Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct link to answers not scrolled to and highlighted #497

Closed
heubeck opened this issue Aug 28, 2023 · 4 comments
Closed

Direct link to answers not scrolled to and highlighted #497

heubeck opened this issue Aug 28, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@heubeck
Copy link

heubeck commented Aug 28, 2023

When navigating to a direct link of a comment, for instance:
/questions/10010000000000062/0?commentId=10070000000000094 or
/questions/10010000000000027/10020000000000056?commentId=10070000000000081
the comment gets highlighted and the page scrolls to its position.

Navigating to anwers, for instance using:
/questions/10010000000000074/10020000000000076
only show the question, not highlighting the answer or scrolling to its position.

Working with notifications would be much easier, having the answer links behaving the same as comment links, as in the notification inbox, there's only stated "user accepted answer question title", navigating to this link only shows the questions top page.

Thank you!

@heubeck heubeck added the enhancement Enhancement request label Aug 28, 2023
@LinkinStars
Copy link
Member

@heubeck Normally, it should scroll to the answer's position and highlight it. For example: https://meta.answer.dev/questions/D1Zb/E11c

Let me make sure that this answer hasn't been deleted right?

@heubeck
Copy link
Author

heubeck commented Aug 28, 2023

Thanks for your response @LinkinStars.
No, the answer is not deleted.

The link given in the notification inbox looks like: /questions/10010000000000104/10020000000000107
Navigating to it neither scrolls nor highlights (browsers tested: firefox desktop, chrome desktop, chrome mobile).

The link to the answer generated by the "share" feature looks like: /questions/10010000000000104/question-title-kebap-case/E1l3 - this one scrolls and highlights.

Is the link provided by the notification inbox correct?

@LinkinStars
Copy link
Member

LinkinStars commented Aug 28, 2023

@heubeck Thanks for the feedback, got it.

@LinkinStars LinkinStars added this to the v1.1.3 milestone Aug 29, 2023
@fenbox fenbox added bug Something isn't working and removed enhancement Enhancement request labels Aug 29, 2023
@fenbox fenbox moved this to In Progress in Answer Roadmap Sep 1, 2023
@LinkinStars
Copy link
Member

Fix in v1.1.3

@github-project-automation github-project-automation bot moved this from In Progress to Done in Answer Roadmap Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants