DataSource values are decorated with extra characters for metrics emitters

[ashwintumma23]

Affected Version

31.0.0
28.0.1

• Tested on these two versions, but the issue will be present on all supported versions

Description

• This issue is very similar to Prometheus extension adding underscores to datasource names in some metrics #17648; and was identified while debugging the parent issue. Credits to @sixtus for identifying the parent issue.
• Metrics reported via SQLExecutionReporter contain heading [ and trailing ] characters for dataSource dimension; which causes inconsistency in reporting dataSource names throughout all the metrics
• Identified the issue in the following emitters; and will be able to be reproduce on other emitters as well
  • Prometheus Emitter

• Kafka Emitter

• Logging Emitter

Root Cause

• We can see that in the following piece of code in SQLExecutionReporter, a List is being converted to String; which causes the [ and ']' to be added to the dataSource label

        String dataSourcesResourceNames = stmt.authResult.sqlResourceActions
                .stream()
                .map(action -> action.getResource().getName())
                .collect(Collectors.toList())
                .toString();