Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ProfileUtil.createDependency() to support platform() and testFixtures() dependencies #14042

Open
jamesfredley opened this issue Feb 27, 2025 · 1 comment
Open

Update ProfileUtil.createDependency() to support platform() and testFixtures() dependencies #14042

jamesfredley opened this issue Feb 27, 2025 · 1 comment

Comments

@jamesfredley
Copy link
Contributor

Issue description

https://github.com/grails/grails-core/blob/7cbbdf62052ffc5ca1a2b9d41d5967acfa6e3c07/grails-shell/src/main/groovy/org/grails/cli/profile/ProfileUtil.groovy#L15

If currently wraps them in double quotes, which is invalid.

Examples:

integrationTestImplementation "testFixtures("org.grails.plugins:geb")"
implementation "platform("org.grails:grails-bom:$grailsVersion")"
@jamesfredley
Copy link
Contributor Author

When this is updated https://github.com/grails/grails-profiles/pull/14/files#diff-a7fc43c385559c6931ec4e0904b83f63fbb414c3ce7e380459c25b340037db9b can be moved back to the yml file for the geb feature instead of being included directly in build.gradle.

@jamesfredley jamesfredley mentioned this issue Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesfredley