-
Notifications
You must be signed in to change notification settings - Fork 269
Support writing to a table with sort-order #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Fokko |
@vinjai Great, I've assigned it to you! |
Hey @Fokko Question around transformation defined in SortOrder:
I am more in favor of the first one. |
For instance (in BucketTransform): iceberg-python/pyiceberg/transforms.py Lines 303 to 304 in 0bf175d
|
@vinjai Since we ignore the write-order today, I think proceeding is fine. Maybe raise a warning so the user knows the data isn't being sorted. Sorting in Python would be very costly. |
Let's pass this to the next release when we have all the transforms implemented using the Rust extension. cc @sungwy |
Hey @Fokko I'm not completely sure about the details of the Rust Extension implementation. |
Feature Request / Improvement
We fail when we see a sort order, it would be great if we could sort+write the data based on the sort-order.
The text was updated successfully, but these errors were encountered: