[MCHECKSTYLE-412] Exclude generated sources / test-sources from default source / test-source directories

Author: gmshake

src/main/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleReport.java

@@ -24,6 +24,7 @@
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
@@ -698,7 +699,7 @@ private boolean checkMavenJxrPluginIsConfigured() {
 
     protected List<File> getSourceDirectories() {
         if (sourceDirectories == null) {
-            sourceDirectories = project.getCompileSourceRoots();
+            sourceDirectories = filterBuildTarget(project.getCompileSourceRoots());
         }
         List<File> sourceDirs = new ArrayList<>(sourceDirectories.size());
         for (String sourceDir : sourceDirectories) {
@@ -709,12 +710,27 @@ protected List<File> getSourceDirectories() {
 
     protected List<File> getTestSourceDirectories() {
         if (testSourceDirectories == null) {
-            testSourceDirectories = project.getTestCompileSourceRoots();
+            testSourceDirectories = filterBuildTarget(project.getTestCompileSourceRoots());
         }
         List<File> testSourceDirs = new ArrayList<>(testSourceDirectories.size());
         for (String testSourceDir : testSourceDirectories) {
             testSourceDirs.add(FileUtils.resolveFile(project.getBasedir(), testSourceDir));
         }
         return testSourceDirs;
     }
+
+    private List<String> filterBuildTarget(List<String> sourceDirectories) {
+        List<String> filtered = new ArrayList<>(sourceDirectories.size());
+        Path buildTarget = FileUtils.resolveFile(
+                        project.getBasedir(), project.getBuild().getDirectory())
+                .toPath();
+
+        for (String sourceDir : sourceDirectories) {
+            Path src = FileUtils.resolveFile(project.getBasedir(), sourceDir).toPath();
+            if (!src.startsWith(buildTarget)) {
+                filtered.add(sourceDir);
+            }
+        }
+        return filtered;
+    }
 }

src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java

@@ -27,6 +27,7 @@
 import java.io.OutputStream;
 import java.io.Reader;
 import java.nio.file.Files;
+import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -833,7 +834,7 @@ private List<Artifact> getCheckstylePluginDependenciesAsArtifacts(Map<String, Pl
 
     private List<File> getSourceDirectories() {
         if (sourceDirectories == null) {
-            sourceDirectories = project.getCompileSourceRoots();
+            sourceDirectories = filterBuildTarget(project.getCompileSourceRoots());
         }
         List<File> sourceDirs = new ArrayList<>(sourceDirectories.size());
         for (String sourceDir : sourceDirectories) {
@@ -844,12 +845,27 @@ private List<File> getSourceDirectories() {
 
     private List<File> getTestSourceDirectories() {
         if (testSourceDirectories == null) {
-            testSourceDirectories = project.getTestCompileSourceRoots();
+            testSourceDirectories = filterBuildTarget(project.getTestCompileSourceRoots());
         }
         List<File> testSourceDirs = new ArrayList<>(testSourceDirectories.size());
         for (String testSourceDir : testSourceDirectories) {
             testSourceDirs.add(FileUtils.resolveFile(project.getBasedir(), testSourceDir));
         }
         return testSourceDirs;
     }
+
+    private List<String> filterBuildTarget(List<String> sourceDirectories) {
+        List<String> filtered = new ArrayList<>(sourceDirectories.size());
+        Path buildTarget = FileUtils.resolveFile(
+                        project.getBasedir(), project.getBuild().getDirectory())
+                .toPath();
+
+        for (String sourceDir : sourceDirectories) {
+            Path src = FileUtils.resolveFile(project.getBasedir(), sourceDir).toPath();
+            if (!src.startsWith(buildTarget)) {
+                filtered.add(sourceDir);
+            }
+        }
+        return filtered;
+    }
 }

src/test/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojoTest.java

@@ -20,6 +20,8 @@
 
 import java.io.File;
 import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import org.apache.maven.model.Build;
 import org.apache.maven.plugin.Mojo;
@@ -142,6 +144,16 @@ public File getFile() {
                 return new File(getBasedir(), "target/classes");
             }
 
+            @Override
+            public List<String> getCompileSourceRoots() {
+                return Collections.emptyList();
+            }
+
+            @Override
+            public List<String> getTestCompileSourceRoots() {
+                return Collections.emptyList();
+            }
+
             public Build getBuild() {
                 return new Build() {
                     private static final long serialVersionUID = -743084937617131258L;