Skip to content

Commit 769da0a

Browse files
[MENFORCER-462] Execute ReactorModuleConvergence only once
Rule checks whole reactor of current build so can be executed once in session
1 parent 3e12af9 commit 769da0a

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/ReactorModuleConvergence.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,11 @@ private void addMessageIfExist(StringBuilder sb) {
392392
}
393393
}
394394

395+
@Override
396+
public String getCacheId() {
397+
return String.valueOf(toString().hashCode());
398+
}
399+
395400
@Override
396401
public String toString() {
397402
return String.format(

enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/ReactorModuleConvergenceTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.junit.jupiter.api.BeforeEach;
3333
import org.junit.jupiter.api.Test;
3434

35+
import static org.assertj.core.api.Assertions.assertThat;
3536
import static org.junit.jupiter.api.Assertions.assertThrows;
3637
import static org.mockito.Mockito.mock;
3738
import static org.mockito.Mockito.when;
@@ -221,6 +222,11 @@ void shouldFailWithWrongDependencyInReactor() {
221222
// intentionally no assertTrue() cause we expect getting an exception.
222223
}
223224

225+
@Test
226+
void cacheIdShouldBeSet() {
227+
assertThat(rule.getCacheId()).isNotEmpty();
228+
}
229+
224230
/**
225231
* This small setup is equivalent to the following situation:
226232
*

0 commit comments

Comments
 (0)