Jahangir yelp/fix iceberg database location #5260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #5259
This PR fixes an issue where Paimon registers an incorrect database location in Glue (or another catalog) when using IcebergOptions.StorageType.TABLE_LOCATION.
Issue Details:
When creating a Paimon table with Iceberg compatibility and setting:
'metadata.iceberg.storage' = 'table-location'
Paimon automatically creates the database and table in Glue if they do not already exist.
However, the registered database location does not match the actual table location, causing unexpected behavior.
This issue affects Iceberg readers and AWS Lake Formation, which rely on the correct database location for access control.
Tests
The following unit tests (UT) were added:
IcebergCommitCallbackTest#testCatalogDatabasePath (Parameterized test for different storage types)
IcebergCommitCallbackTest#testCatalogTableMetadataPath (Ensures correct metadata path resolution)
API and Format
No change
Documentation
No new feature introduced