Skip to content

Commit 2586134

Browse files
authored
fix(elasticsearch): add is_collection to documentation (#5497)
1 parent 43394b4 commit 2586134

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

src/Elasticsearch/Filter/AbstractSearchFilter.php

+1
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ public function getDescription(string $resourceClass): array
9696
'property' => $property,
9797
'type' => $hasAssociation ? 'string' : $this->getPhpType($type),
9898
'required' => false,
99+
'is_collection' => str_ends_with((string) $filterParameterName, '[]'),
99100
];
100101
}
101102
}

tests/Elasticsearch/Filter/MatchFilterTest.php

+8
Original file line numberDiff line numberDiff line change
@@ -176,41 +176,49 @@ public function testGetDescription(): void
176176
'property' => 'id',
177177
'type' => 'int',
178178
'required' => false,
179+
'is_collection' => false,
179180
],
180181
'id[]' => [
181182
'property' => 'id',
182183
'type' => 'int',
183184
'required' => false,
185+
'is_collection' => true,
184186
],
185187
'name' => [
186188
'property' => 'name',
187189
'type' => 'string',
188190
'required' => false,
191+
'is_collection' => false,
189192
],
190193
'name[]' => [
191194
'property' => 'name',
192195
'type' => 'string',
193196
'required' => false,
197+
'is_collection' => true,
194198
],
195199
'date' => [
196200
'property' => 'date',
197201
'type' => \DateTimeInterface::class,
198202
'required' => false,
203+
'is_collection' => false,
199204
],
200205
'date[]' => [
201206
'property' => 'date',
202207
'type' => \DateTimeInterface::class,
203208
'required' => false,
209+
'is_collection' => true,
204210
],
205211
'weird' => [
206212
'property' => 'weird',
207213
'type' => 'string',
208214
'required' => false,
215+
'is_collection' => false,
209216
],
210217
'weird[]' => [
211218
'property' => 'weird',
212219
'type' => 'string',
213220
'required' => false,
221+
'is_collection' => true,
214222
],
215223
],
216224
$matchFilter->getDescription(Foo::class)

tests/Elasticsearch/Filter/TermFilterTest.php

+8
Original file line numberDiff line numberDiff line change
@@ -176,41 +176,49 @@ public function testGetDescription(): void
176176
'property' => 'id',
177177
'type' => 'int',
178178
'required' => false,
179+
'is_collection' => false,
179180
],
180181
'id[]' => [
181182
'property' => 'id',
182183
'type' => 'int',
183184
'required' => false,
185+
'is_collection' => true,
184186
],
185187
'name' => [
186188
'property' => 'name',
187189
'type' => 'string',
188190
'required' => false,
191+
'is_collection' => false,
189192
],
190193
'name[]' => [
191194
'property' => 'name',
192195
'type' => 'string',
193196
'required' => false,
197+
'is_collection' => true,
194198
],
195199
'date' => [
196200
'property' => 'date',
197201
'type' => \DateTimeInterface::class,
198202
'required' => false,
203+
'is_collection' => false,
199204
],
200205
'date[]' => [
201206
'property' => 'date',
202207
'type' => \DateTimeInterface::class,
203208
'required' => false,
209+
'is_collection' => true,
204210
],
205211
'weird' => [
206212
'property' => 'weird',
207213
'type' => 'string',
208214
'required' => false,
215+
'is_collection' => false,
209216
],
210217
'weird[]' => [
211218
'property' => 'weird',
212219
'type' => 'string',
213220
'required' => false,
221+
'is_collection' => true,
214222
],
215223
],
216224
$termFilter->getDescription(Foo::class)

0 commit comments

Comments
 (0)