fix(symfony): property info with doctrine collections

Author: soyuka

src/JsonSchema/Metadata/Property/Factory/SchemaPropertyMetadataFactory.php

@@ -19,6 +19,7 @@
 use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
 use ApiPlatform\Metadata\ResourceClassResolverInterface;
 use ApiPlatform\Metadata\Util\ResourceClassInfoTrait;
+use Doctrine\Common\Collections\ArrayCollection;
 use Ramsey\Uuid\UuidInterface;
 use Symfony\Component\PropertyInfo\Type;
 use Symfony\Component\Uid\Ulid;
@@ -110,6 +111,11 @@ public function create(string $resourceClass, string $property, array $options =
 
         $valueSchema = [];
         foreach ($types as $type) {
+            // Temp fix for https://github.com/symfony/symfony/pull/52699
+            if (ArrayCollection::class === $type->getClassName()) {
+                $type = new Type($type->getBuiltinType(), $type->isNullable(), $type->getClassName(), true, $type->getCollectionKeyTypes(), $type->getCollectionValueTypes());
+            }
+
             if ($isCollection = $type->isCollection()) {
                 $keyType = $type->getCollectionKeyTypes()[0] ?? null;
                 $valueType = $type->getCollectionValueTypes()[0] ?? null;

src/Metadata/Property/Factory/PropertyInfoPropertyMetadataFactory.php

@@ -15,7 +15,9 @@
 
 use ApiPlatform\Metadata\ApiProperty;
 use ApiPlatform\Metadata\Exception\PropertyNotFoundException;
+use Doctrine\Common\Collections\ArrayCollection;
 use Symfony\Component\PropertyInfo\PropertyInfoExtractorInterface;
+use Symfony\Component\PropertyInfo\Type;
 
 /**
  * PropertyInfo metadata loader decorator.
@@ -44,7 +46,16 @@ public function create(string $resourceClass, string $property, array $options =
         }
 
         if (!$propertyMetadata->getBuiltinTypes()) {
-            $propertyMetadata = $propertyMetadata->withBuiltinTypes($this->propertyInfo->getTypes($resourceClass, $property, $options) ?? []);
+            $types = $this->propertyInfo->getTypes($resourceClass, $property, $options) ?? [];
+
+            foreach ($types as $i => $type) {
+                // Temp fix for https://github.com/symfony/symfony/pull/52699
+                if (ArrayCollection::class === $type->getClassName()) {
+                    $types[$i] = new Type($type->getBuiltinType(), $type->isNullable(), $type->getClassName(), true, $type->getCollectionKeyTypes(), $type->getCollectionValueTypes());
+                }
+            }
+
+            $propertyMetadata = $propertyMetadata->withBuiltinTypes($types);
         }
 
         if (null === $propertyMetadata->getDescription() && null !== $description = $this->propertyInfo->getShortDescription($resourceClass, $property, $options)) {

tests/Fixtures/TestBundle/ApiResource/Issue5501/BrokenDocs.php

@@ -30,7 +30,7 @@ class BrokenDocs
     public ?int $id = null;
 
     /**
-     * @var ?Related[]
+     * @var ?ArrayCollection<Related>
      */
     #[Groups(['location:write', 'location:read_collection'])]
     public ?ArrayCollection $locations;