Simplify refactored OpenApiFactory collectPaths()

guilliamxavier · web-flow · commit 737ad8d051e5 · 2021-04-09T10:43:41.000+02:00
diff --git a/src/OpenApi/Factory/OpenApiFactory.php b/src/OpenApi/Factory/OpenApiFactory.php
@@ -128,7 +128,7 @@ private function collectPaths(ResourceMetadata $resourceMetadata, string $resour
         $resourceShortName = $resourceMetadata->getShortName();
         $operations = OperationType::COLLECTION === $operationType ? $resourceMetadata->getCollectionOperations() : (OperationType::ITEM === $operationType ? $resourceMetadata->getItemOperations() : $this->subresourceOperationFactory->create($resourceClass));
         if (!$operations) {
-            return [$links, $schemas];
+            return;
         }
 
         $rootResourceClass = $resourceClass;
@@ -286,8 +286,6 @@ private function collectPaths(ResourceMetadata $resourceMetadata, string $resour
 
             $paths->addPath($path, $pathItem);
         }
-
-        return [$links, $schemas];
     }
 
     private function buildContent(array $responseMimeTypes, array $operationSchemas): \ArrayObject

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ private function collectPaths(ResourceMetadata $resourceMetadata, string $resour`
`128`	`128`	`$resourceShortName = $resourceMetadata->getShortName();`
`129`	`129`	`$operations = OperationType::COLLECTION === $operationType ? $resourceMetadata->getCollectionOperations() : (OperationType::ITEM === $operationType ? $resourceMetadata->getItemOperations() : $this->subresourceOperationFactory->create($resourceClass));`
`130`	`130`	`if (!$operations) {`
`131`		`- return [$links, $schemas];`
	`131`	`+ return;`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`$rootResourceClass = $resourceClass;`
`@@ -286,8 +286,6 @@ private function collectPaths(ResourceMetadata $resourceMetadata, string $resour`
`286`	`286`
`287`	`287`	`$paths->addPath($path, $pathItem);`
`288`	`288`	`}`
`289`		`-`
`290`		`- return [$links, $schemas];`
`291`	`289`	`}`
`292`	`290`
`293`	`291`	`private function buildContent(array $responseMimeTypes, array $operationSchemas): \ArrayObject`