fix: filters don't have to implement the "legacy" FilterInterface (#5619)

mrossard · web-flow · commit a8796238d7ff · 2023-06-08T16:51:57.000+02:00
Co-authored-by: Manuel Rossard &lt;manuel.rossard@u-bordeaux.fr&gt;
diff --git a/src/Metadata/ApiFilter.php b/src/Metadata/ApiFilter.php
@@ -34,7 +34,7 @@ public function __construct(
         public array $properties = [],
         public array $arguments = [],
     ) {
-        if (!is_a($this->filterClass, FilterInterface::class, true) || !is_a($this->filterClass, LegacyFilterInterface::class, true)) {
+        if (!is_a($this->filterClass, FilterInterface::class, true) && !is_a($this->filterClass, LegacyFilterInterface::class, true)) {
             throw new InvalidArgumentException(sprintf('The filter class "%s" does not implement "%s". Did you forget a use statement?', $this->filterClass, FilterInterface::class));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function __construct(`
`34`	`34`	`public array $properties = [],`
`35`	`35`	`public array $arguments = [],`
`36`	`36`	`) {`
`37`		`- if (!is_a($this->filterClass, FilterInterface::class, true) \|\| !is_a($this->filterClass, LegacyFilterInterface::class, true)) {`
	`37`	`+ if (!is_a($this->filterClass, FilterInterface::class, true) && !is_a($this->filterClass, LegacyFilterInterface::class, true)) {`
`38`	`38`	`throw new InvalidArgumentException(sprintf('The filter class "%s" does not implement "%s". Did you forget a use statement?', $this->filterClass, FilterInterface::class));`
`39`	`39`	`}`
`40`	`40`	`}`