chore(deprecations): fix symfony deprecations (#5289)

* [Chore] Remove deprecated MessageHandlerInterface from tests

* [Chore] Replace deprecated ArgumentValueResolverInterface, supports logic now needs to be in resolve as well

* [Chore] Swap loose mode with html5 mode

Author: KDederichs

src/Symfony/Bundle/ArgumentResolver/PayloadArgumentResolver.php

@@ -18,10 +18,10 @@
 use ApiPlatform\Util\OperationRequestInitiatorTrait;
 use ApiPlatform\Util\RequestAttributesExtractor;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface;
+use Symfony\Component\HttpKernel\Controller\ValueResolverInterface;
 use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
 
-final class PayloadArgumentResolver implements ArgumentValueResolverInterface
+final class PayloadArgumentResolver implements ValueResolverInterface
 {
     use OperationRequestInitiatorTrait;
 
@@ -59,6 +59,10 @@ public function supports(Request $request, ArgumentMetadata $argument): bool
 
     public function resolve(Request $request, ArgumentMetadata $argument): \Generator
     {
+        if (!$this->supports($request, $argument)) {
+            yield [];
+        }
+
         yield $request->attributes->get('data');
     }
 

tests/Fixtures/TestBundle/MessageHandler/PasswordResetRequestHandler.php

@@ -16,9 +16,10 @@
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\PasswordResetRequest;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\PasswordResetRequestResult;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 
-class PasswordResetRequestHandler implements MessageHandlerInterface
+#[AsMessageHandler]
+class PasswordResetRequestHandler
 {
     public function __invoke(PasswordResetRequest $passwordResetRequest): PasswordResetRequestResult
     {

tests/Fixtures/TestBundle/MessengerHandler/Document/MessengerWithInputHandler.php

@@ -15,9 +15,10 @@
 
 use ApiPlatform\Tests\Fixtures\TestBundle\Document\MessengerWithInput;
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\MessengerInput;
-use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 
-class MessengerWithInputHandler implements MessageHandlerInterface
+#[AsMessageHandler]
+class MessengerWithInputHandler
 {
     public function __invoke(MessengerInput $data): MessengerWithInput
     {

tests/Fixtures/TestBundle/MessengerHandler/Entity/MessengerWithInputHandler.php

@@ -15,9 +15,10 @@
 
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\MessengerInput;
 use ApiPlatform\Tests\Fixtures\TestBundle\Entity\MessengerWithInput;
-use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 
-class MessengerWithInputHandler implements MessageHandlerInterface
+#[AsMessageHandler]
+class MessengerWithInputHandler
 {
     public function __invoke(MessengerInput $data): MessengerWithInput
     {

tests/Fixtures/TestBundle/MessengerHandler/MessengerWithResponseHandler.php

@@ -15,9 +15,10 @@
 
 use ApiPlatform\Tests\Fixtures\TestBundle\Dto\MessengerResponseInput;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Messenger\Handler\MessageHandlerInterface;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 
-class MessengerWithResponseHandler implements MessageHandlerInterface
+#[AsMessageHandler]
+class MessengerWithResponseHandler
 {
     public function __invoke(MessengerResponseInput $data): Response
     {

tests/Symfony/Validator/Metadata/Property/Restriction/PropertySchemaCollectionRestrictionTest.php

@@ -85,7 +85,7 @@ public function createProvider(): \Generator
             'email' => [
                 new NotNull(),
                 new Length(['min' => 2, 'max' => 255]),
-                new Email(['mode' => Email::VALIDATION_MODE_LOOSE]),
+                new Email(['mode' => Email::VALIDATION_MODE_HTML5]),
             ],
             'phone' => new Optional([
                 new Type(['type' => 'string']),