fix(jsonshcema): make sure that the shortName is used

Author: Zowac

features/openapi/docs.feature

@@ -299,3 +299,24 @@ Feature: Documentation support
     And the JSON node "components.schemas.RamseyUuidDummy.properties.id.description" should be equal to "The dummy id."
     And the JSON node "components.schemas.RelatedDummy-barcelona" should not exist
     And the JSON node "components.schemas.RelatedDummybarcelona" should exist
+
+  @!mongodb
+  Scenario: Retrieve the OpenAPI documentation to see if shortName property is used
+    Given I send a "GET" request to "/docs.json"
+    Then the response status code should be 200
+    And the response should be in JSON
+    And the header "Content-Type" should be equal to "application/json; charset=utf-8"
+    And the OpenAPI class "Resource" exists
+    And the OpenAPI class "RelatedResource" exists
+    And the "resourceRelated" property for the OpenAPI class "Resource" should be equal to:
+    """
+    {
+      "readOnly":true,
+      "anyOf":[
+        {
+          "$ref":"#/components/schemas/RelatedResource"
+        }
+      ],
+      "nullable":true
+    }
+    """

src/JsonSchema/SchemaFactory.php

@@ -291,10 +291,6 @@ private function getMetadata(string $className, string $type = Schema::TYPE_OUTP
                                 $operation = $op;
                                 break 2;
                             }
-
-                            if (!$operation) {
-                                $operation = new HttpOperation();
-                            }
                         }
                     }
                 }

tests/Fixtures/TestBundle/Entity/JsonSchemaResource.php

@@ -0,0 +1,29 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\Entity;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+
+#[ApiResource(
+    shortName: 'Resource',
+)]
+class JsonSchemaResource
+{
+    #[ApiProperty(identifier: true)]
+    public $id;
+
+    #[ApiProperty(writable: false, readableLink: true)]
+    public ?JsonSchemaResourceRelated $resourceRelated = null;
+}

tests/Fixtures/TestBundle/Entity/JsonSchemaResourceRelated.php

@@ -0,0 +1,26 @@
+<?php
+
+/*
+ * This file is part of the API Platform project.
+ *
+ * (c) Kévin Dunglas <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace ApiPlatform\Tests\Fixtures\TestBundle\Entity;
+
+use ApiPlatform\Metadata\ApiProperty;
+use ApiPlatform\Metadata\ApiResource;
+
+#[ApiResource(
+    shortName: 'RelatedResource',
+)]
+class JsonSchemaResourceRelated
+{
+    #[ApiProperty(identifier: true)]
+    public $id;
+}