feat: add unknown operation for test (#9)

Author: bzp2010

.github/workflows/ci.yml

@@ -43,7 +43,7 @@ jobs:
 
       - name: script
         run: |
-          sudo docker run --detach --rm --name openldap -p 1389:1389 -p 1636:1636 -v $PWD/t/certs:/opt/bitnami/openldap/certs -e LDAP_ENABLE_TLS=yes -e LDAP_TLS_CERT_FILE=/opt/bitnami/openldap/certs/localhost_slapd_cert.pem -e LDAP_TLS_KEY_FILE=/opt/bitnami/openldap/certs/localhost_slapd_key.pem -e LDAP_TLS_CA_FILE=/opt/bitnami/openldap/certs/mycacert.crt -e LDAP_USERS=user01,user02 -e LDAP_PASSWORDS=password1,password2 bitnami/openldap:2.6
+          sudo docker run --detach --rm --name openldap -p 1389:1389 -p 1636:1636 -v $PWD/t/certs:/opt/bitnami/openldap/certs -e LDAP_ENABLE_TLS=yes -e LDAP_TLS_CERT_FILE=/opt/bitnami/openldap/certs/localhost_slapd_cert.pem -e LDAP_TLS_KEY_FILE=/opt/bitnami/openldap/certs/localhost_slapd_key.pem -e LDAP_TLS_CA_FILE=/opt/bitnami/openldap/certs/mycacert.crt -e LDAP_ADMIN_USERNAME=admin -e LDAP_ADMIN_PASSWORD=adminpassword -e LDAP_USERS=user01,user02 -e LDAP_PASSWORDS=password1,password2 bitnami/openldap:2.6
           sleep 3
           export PATH=$OPENRESTY_PREFIX/nginx/sbin:$OPENRESTY_PREFIX/luajit/bin:$PATH
           make test

Makefile

@@ -21,4 +21,6 @@ help:
 	@grep -E '^### [-A-Za-z0-9_]+:' Makefile | sed 's/###/   /'
 
 test:
+	git apply t/patch/unknown_op.patch
 	prove -r t/
+	git apply t/patch/unknown_op.patch -R

t/patch/unknown_op.patch

@@ -0,0 +1,19 @@
+diff --git a/lib/resty/ldap/client.lua b/lib/resty/ldap/client.lua
+index 6b8eb18..45cef3f 100644
+--- a/lib/resty/ldap/client.lua
++++ b/lib/resty/ldap/client.lua
+@@ -257,4 +257,14 @@ function _M.search(self, base_dn, scope, deref_aliases, size_limit, time_limit,
+ end
+ 
+ 
++function _M.unknown(self, hex_data, multi_resp_hint)
++    local raw_data = hex_data:gsub("%x%x", function(digits) return string.char(tonumber(digits, 16)) end)
++    local res, err = _send_recieve(self, raw_data, multi_resp_hint or false)
++    if not res then
++        return false, err
++    end
++    return res
++end
++
++
+ return _M

t/search.t

@@ -571,3 +571,118 @@ GET /t
 --- no_error_log
 [error]
 --- error_code: 200
+
+
+
+=== TEST 17: add new Chinese attribute to user01
+--- http_config eval: $::HttpConfig
+--- config
+    location /t {
+        content_by_lua_block {
+            local ldap_client = require("resty.ldap.client")
+            local ldap_protocol = require("resty.ldap.protocol")
+
+            local client = ldap_client:new("127.0.0.1", 1389)
+
+            -- auth
+            local res, err = client:simple_bind("cn=admin,dc=example,dc=org", "adminpassword")
+            if not res then
+                ngx.log(ngx.ERR, err)
+                ngx.exit(401)
+            end
+
+            assert(res, "failed to bind admin")
+
+            -- modify
+            local res, err = client:unknown(
+                "304b02012266460424636e3d7573657230312c6f753d75736572732c64633d6578616d706c652c64633d6f7267301e301c0a01003017040b646973706c61794e616d6531080406e4b8ade69687", -- hex
+                false
+            )
+            if not res then
+                ngx.log(ngx.ERR, err)
+                ngx.exit(401)
+            end
+
+            assert(res.protocol_op == 7, "protocol_op is not equal to 7, " .. res.protocol_op)
+            assert(res.result_code == 0, "result_code is not equal to 0, " .. res.result_code)
+        }
+    }
+--- request
+GET /t
+--- no_error_log
+[error]
+--- error_code: 200
+
+
+
+=== TEST 18: search filter (attribute value in Chinese)
+--- http_config eval: $::HttpConfig
+--- config
+    location /t {
+        content_by_lua_block {
+            local ldap_client = require("resty.ldap.client")
+            local ldap_protocol = require("resty.ldap.protocol")
+
+            local client = ldap_client:new("127.0.0.1", 1389)
+            local res, err = client:search(
+                "dc=example,dc=org",
+                ldap_protocol.SEARCH_SCOPE_WHOLE_SUBTREE, nil, nil, nil, nil,
+                "(displayName=中文)", {"gidNumber"}
+            )
+
+            if not res then
+                ngx.log(ngx.ERR, err)
+                ngx.exit(401)
+            end
+
+            assert(#res == 1, "result length is not equal to 1")
+            assert(res[1].entryDN == "cn=user01,ou=users,dc=example,dc=org", "result entryDN is not equal to cn=user01,ou=users,dc=example,dc=org")
+            assert(res[1].attributes.gidNumber == "1000", "result gidNumber attribute is not equal to 1000")
+        }
+    }
+--- request
+GET /t
+--- no_error_log
+[error]
+--- error_code: 200
+
+
+
+=== TEST 19: remove Chinese attribute in user01
+--- http_config eval: $::HttpConfig
+--- config
+    location /t {
+        content_by_lua_block {
+            local ldap_client = require("resty.ldap.client")
+            local ldap_protocol = require("resty.ldap.protocol")
+
+            local client = ldap_client:new("127.0.0.1", 1389)
+
+            -- auth
+            local res, err = client:simple_bind("cn=admin,dc=example,dc=org", "adminpassword")
+            if not res then
+                ngx.log(ngx.ERR, err)
+                ngx.exit(401)
+            end
+
+            assert(res, "failed to bind admin")
+
+            -- modify
+            local res, err = client:unknown(
+                "304b02014066460424636e3d7573657230312c6f753d75736572732c64633d6578616d706c652c64633d6f7267301e301c0a01013017040b646973706c61794e616d6531080406e4b8ade69687", -- hex
+                false
+            )
+            if not res then
+                ngx.log(ngx.ERR, err)
+                ngx.exit(401)
+            end
+
+            assert(res.protocol_op == 7, "protocol_op is not equal to 7, " .. res.protocol_op)
+            assert(res.result_code == 0, "result_code is not equal to 0, " .. res.result_code)
+        }
+    }
+--- request
+GET /t
+--- no_error_log
+[error]
+--- error_code: 200