Skip to content
This repository was archived by the owner on Aug 14, 2020. It is now read-only.

support both go 1.3 and go 1.4 static compilation #9

Closed
jonboulle opened this issue Feb 18, 2015 · 6 comments
Closed

support both go 1.3 and go 1.4 static compilation #9

jonboulle opened this issue Feb 18, 2015 · 6 comments

Comments

@jonboulle
Copy link
Contributor

goaci should be able to compile statically on both go 1.3 and go 1.4 (currently it lacks the necessary arguments for 1.4 - golang/go#9344)

@krnowak
Copy link
Member

krnowak commented Feb 19, 2015

That is fixed in master, so it could be closed. The only thing that doesn't work is that using installsuffix tries to install static version of std library in $GOROOT/pkg/linux_amd64_cgo (we use -installsuffix cgo), which is a problem when using go provided by a distro - usually $GOROOT is something like /usr/lib/golang, where only root has write access.

@jonboulle
Copy link
Contributor Author

It's not actually fixed on master because #2 hasn't landed yet.

I am concerned about this -installsuffix thing, and surprised this isn't an upstream golang issue for this? Should we file one?

@krnowak
Copy link
Member

krnowak commented Feb 20, 2015

Well, it really is fixed - https://github.com/appc/goaci/blob/master/goaci.go#L74. You probably pushed that by accident. So I rebased my changes against it and modified my fix to only remove an obsolete TODO.

And about installsuffix - golang/go#9344 (comment). If you are concerned about installsuffix and permission problems then do you want me to file an issue about it? Probably a new env var GOPKG which would be for pkg directory like GOBIN for bin directory could be a solution?

@jonboulle
Copy link
Contributor Author

You probably pushed that by accident.

whoops :-(
I don't suppose you confirmed this still works for 1.3?

If you are concerned about installsuffix and permission problems then do you want me to file an issue about it?

Yes please, I would like to know what upstream thinks about this, seems like a bit of a bug to me.

@krnowak
Copy link
Member

krnowak commented Feb 26, 2015

The installsuffix option works well for 1.3 too. @philips told me to ignore the distro-provided go for now, but I filed a bug anyway - golang/go#10011.

I suppose I can close this one for now.

@krnowak krnowak closed this as completed Feb 26, 2015
@krnowak
Copy link
Member

krnowak commented Feb 26, 2015

A followup is here: #11.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants