fix: Validate presence package configuration

Author: kgilpin

lib/appmap/config.rb

@@ -176,8 +176,8 @@ def method_hook(cls, method_names, labels)
       package_hooks('actionpack',
         [
           method_hook('ActionDispatch::Request::Session', %i[[] dig values fetch], %w[http.session.read]),
-          method_hook('ActionDispatch::Request::Session', %i[destroy[]= clear update delete merge], %w[http.session.write]),
-          method_hook('ActionDispatch::Cookies::CookieJar', %i[[]= clear update delete recycle], %w[http.session.read]),
+          method_hook('ActionDispatch::Request::Session', %i[destroy []= clear update delete merge], %w[http.session.write]),
+          method_hook('ActionDispatch::Cookies::CookieJar', %i[[] fetch], %w[http.session.read]),
           method_hook('ActionDispatch::Cookies::CookieJar', %i[[]= clear update delete recycle], %w[http.session.write]),
           method_hook('ActionDispatch::Cookies::EncryptedCookieJar', %i[[]= clear update delete recycle], %w[http.cookie crypto.encrypt])
         ],
@@ -360,6 +360,7 @@ def load(config_data)
               gem = package['gem']
               path = package['path']
               raise %q(AppMap config 'package' element should specify 'gem' or 'path', not both) if gem && path
+              raise %q(AppMap config 'package' element should specify 'gem' or 'path') unless gem || path
 
               if gem
                 shallow = package['shallow']

spec/fixtures/config/missing_path_or_gem.yml

@@ -0,0 +1,3 @@
+name: name
+packages:
+  - dogs: are friendly

test/agent_setup_validate_test.rb

@@ -6,6 +6,7 @@ class AgentSetupValidateTest < Minitest::Test
   NON_EXISTING_CONFIG_FILENAME = '123.yml'
   INVALID_YAML_CONFIG_FILENAME = 'spec/fixtures/config/invalid_yaml_config.yml'
   INVALID_CONFIG_FILENAME = 'spec/fixtures/config/invalid_config.yml'
+  MISSING_PATH_OR_GEM_CONFIG_FILENAME = 'spec/fixtures/config/missing_path_or_gem.yml'
 
   def test_init_when_config_exists
     output = `./exe/appmap-agent-validate`
@@ -72,4 +73,22 @@ def test_init_with_invalid_data_config
     ])
     assert_equal expected, output.strip
   end
+
+  def test_init_with_missing_package_key
+    output = `./exe/appmap-agent-validate -c #{MISSING_PATH_OR_GEM_CONFIG_FILENAME}`
+    assert_equal 0, $CHILD_STATUS.exitstatus
+    expected = JSON.pretty_generate([
+      {
+        level: :error,
+        message: 'AppMap auto-configuration is currently not available for non Rails projects'
+      },
+      {
+        level: :error,
+        filename: MISSING_PATH_OR_GEM_CONFIG_FILENAME,
+        message: "AppMap configuration #{MISSING_PATH_OR_GEM_CONFIG_FILENAME} could not be loaded",
+        detailed_message: "AppMap config 'package' element should specify 'gem' or 'path'"
+      }
+    ])
+    assert_equal expected, output.strip
+  end
 end